Repository navigation
Revert "tp: fix compile on windows by adding noreturn conditionally (… - #2948
Merged
Merged
Conversation
…2914)" This reverts commit db14c6a. Also adds a conditional PERFETTO_FATAL as suggested in #2914 (comment)
|
🤖 Hi @kraskevich, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
LalitMaganti
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…#2914)"
This reverts commit db14c6a.
Also adds a conditional PERFETTO_FATAL as suggested in #2914 (comment)
The original commit causes perfetto->chromium autoroller failures, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/6950397