Skip to content

Display perf_samples that doesn't have a callsite_id #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haixiaosugoogle wants to merge 3 commits into from
Closed

Display perf_samples that doesn't have a callsite_id #2943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f7bf2a
Display perf samples with null callsites
haixiaosugoogle Sep 15, 2025
b713402
remove commented out code
haixiaosugoogle Sep 15, 2025
e292d33
Merge branch 'main' into dev/haixiaosu/add_empty_sample
haixiaosugoogle Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ui/src/plugins/dev.perfetto.LinuxPerf/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ export default class implements PerfettoPlugin {
FROM perf_sample
JOIN thread USING (utid)
WHERE
callsite_id IS NOT NULL AND
upid IS NOT NULL
`);

Expand Down Expand Up @@ -116,7 +115,6 @@ export default class implements PerfettoPlugin {
upid
from perf_sample
join thread using (utid)
where callsite_id is not null
`);
for (
const it = tResult.iter({
Expand Down
10 changes: 4 additions & 6 deletions ui/src/plugins/dev.perfetto.LinuxPerf/perf_samples_profile_track.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,10 @@ export function createProcessPerfSamplesProfileTrack(
SELECT
p.id,
ts,
callsite_id as callsiteId,
IIF(callsite_id is null, 0, callsite_id) as callsiteId,
upid
FROM perf_sample p
JOIN thread using (utid)
WHERE callsite_id IS NOT NULL
ORDER BY ts
`,
filter: {
Expand All @@ -69,7 +68,7 @@ export function createProcessPerfSamplesProfileTrack(
select
id,
parent_id as parentId,
name,
IIF(name is null, "skipped sample", name) as name,
mapping_name,
source_file || ':' || line_number as source_location,
self_count
Expand Down Expand Up @@ -132,10 +131,9 @@ export function createThreadPerfSamplesProfileTrack(
SELECT
p.id,
ts,
callsite_id as callsiteId,
IIF(callsite_id is null, 0, callsite_id) as callsiteId,
utid
FROM perf_sample p
WHERE callsite_id IS NOT NULL
ORDER BY ts
`,
filter: {
Expand All @@ -152,7 +150,7 @@ export function createThreadPerfSamplesProfileTrack(
select
id,
parent_id as parentId,
name,
IIF(name is null, "skipped sample", name) as name,
mapping_name,
source_file || ':' || line_number as source_location,
self_count
Expand Down