Repository navigation
tp: allow the HTTP RPC accelerator to open more than 1 file #2615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WangJialin547
wants to merge
125
commits into
google:main
Choose a base branch
from
WangJialin547:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
125 commits
Select commit
Hold shift + click to select a range
3b0ad6a
feat: allow multiple tabs to use the HTTP RPC accelerator
WangJialin547 7fc623c
attempt to solve problem 1
WangJialin547 b8b0964
attempt to solve problem 1
WangJialin547 2847b92
added thread pruning mechanic
WangJialin547 589f7fd
Merge branch 'problem1'
WangJialin547 ce0ae70
temp save
WangJialin547 55511f0
changed proto, added modal
WangJialin547 4c6ad28
temp save
WangJialin547 c63b538
format code
WangJialin547 c455bb4
fix modal 2
WangJialin547 2a30a36
solved problem 2
WangJialin547 f91b34e
format files
WangJialin547 b14364f
fixed missing file name bug
WangJialin547 9d19600
added missing message handling
WangJialin547 13bfbdf
fixed segfault issue
WangJialin547 d7ba3d5
update comments
WangJialin547 38a32b5
fix typo
WangJialin547 e822bda
remove unneccessary timeout_mins parameter
WangJialin547 f479da7
changed UuidRpcThread to a class
WangJialin547 fab1acc
renamed IsUuidHandshake function to PascalCase
WangJialin547 c0f5ed7
replaced magic numbers with constexprs kMillisecondPerMinute and kNan…
WangJialin547 9f8b218
renamed firstStatus into firstTpStatus
WangJialin547 33b1524
modify sendTraceTitle method
WangJialin547 d452b41
added mutex protection for /status/all endpoint
WangJialin547 82f3a67
changed default string into a constant
WangJialin547 49d30f3
changed it and it2 to descriptive var name
WangJialin547 b5b96fe
removed unneccessary size 5 check
WangJialin547 8ebd0c0
changed while loop in cleanUpInactiveInstances to for loop
WangJialin547 3aec78e
added uuid local variable in the loop inside of cleanUpInactiveInetances
WangJialin547 c5e16b0
fix
WangJialin547 a26267b
changed atoi to base::StringToInt32
WangJialin547 a885164
removed wrapper function isUuidHandshake
WangJialin547 297d758
fixed comment
WangJialin547 2fa49f1
modified comments
WangJialin547 ce2c631
updated build.gn for httpd to include ../../base:version
WangJialin547 8c485de
supports parsing uuid from message using json_utils.h
WangJialin547 ce2eb59
fix
WangJialin547 45c3e6e
addressed issue 2: the preloaded trace using trace_processor_shell ge…
WangJialin547 3d599dd
added a hasActiveTab field to the status message
WangJialin547 b7d9cd4
new version of popup modal
WangJialin547 26dec05
made processors with active tabs accessible, but display warning
WangJialin547 f1c2f6e
addressed problems 1, 3 and 4 by introducing a new modal
WangJialin547 90db9a3
fixed race condition that cuases a segfault
WangJialin547 cee2299
moved the buttons to the bottom like the old version of the dialog
WangJialin547 a66763b
format code
WangJialin547 27560db
fix
WangJialin547 97c1dd5
fixed warning message
WangJialin547 9e318be
added a mouse hover effect on the file selection buttons
WangJialin547 c2a989f
fixed bug: now trace_processor_shell with no preloaded trace won't cr…
WangJialin547 8ecee5e
attempt to solve CI failure by including json folder in build.gn
WangJialin547 d626381
update comment
WangJialin547 3fe21d6
fixed proto file
WangJialin547 05ef013
shows the trace processor selection modal in all situations
WangJialin547 bd665c0
removed /status/all endpoint
WangJialin547 342acf6
when websocket disconnects, removes tp instance if it has no trace lo…
WangJialin547 cb3d231
fixed the problem where tools/format-sources is complaining
WangJialin547 f30c3a0
apply changes to the modal
WangJialin547 0ce2f6e
fixed rpc_http_dialog
WangJialin547 956440f
added new endpoints for websocket
WangJialin547 7824e8a
solved the race condition problem when closing laptop lid by adding a…
WangJialin547 5148f16
cleanup work, removing unused functions and clarifying comments
WangJialin547 98653ff
changed uuid to monotonic id for tps
WangJialin547 efc72f1
fixed eslint issues when formatting
WangJialin547 427845c
fixed presubmit issues
WangJialin547 5d58355
fixed version mismatch error
WangJialin547 6adfea5
fixed backcomp issue by sending the uuid wrapped in a protobuf messag…
WangJialin547 a8d83c6
modified modal to fit the requirements
WangJialin547 d25b399
moved rpcPolicy
WangJialin547 36b41a1
moved inline styles to a style sheet
WangJialin547 ac0cdc3
removed unneccessary include
WangJialin547 3a762cf
'New Instance...' won't show if there are no tp instances detected as…
WangJialin547 786620b
format code
WangJialin547 e77b2a8
fix presubmit issue
WangJialin547 ee89530
solved segfault issue caused by sending rpc chunk to nonexistent conn…
WangJialin547 266555d
added a /close http endpoint that kills unused tps
WangJialin547 9ae2c07
changed modal id sorting from descending to ascending
WangJialin547 30100a5
kills the respective ws connection when /close request is sent, preve…
WangJialin547 4c6bb7d
fix
WangJialin547 ca315e1
case fix
WangJialin547 7bddd2a
fix
WangJialin547 e7e7bca
change rpc_ to unique_ptr
WangJialin547 325ee60
remove json dependency as no longer needed
WangJialin547 e23e4d7
added detailed comment explaining the self-repeating cleanup task
WangJialin547 8f97186
renamed has_active_tab to is_attached_ and added getters and setters
WangJialin547 47e17e5
format code
WangJialin547 46fa2d5
fixed presubmit issues
WangJialin547 e587e25
changed trace_processor_shell comment
WangJialin547 c9e3212
also closes inactive WS connection in CleaUpInactiveInstances()
WangJialin547 edff7ab
moved sendTraceTitle next to restoreInitialtables
WangJialin547 aab3eb5
removed window.location.hostname:9001 from rpcPolicy
WangJialin547 e281e88
reverted change in http_rpc_engine.hostAndPort()
WangJialin547 64bf3f6
removed redundant RedrawModal() function and replaced with m.redraw()
WangJialin547 c4b68a8
removed unneccessary m.redraw
WangJialin547 ef316f2
Revert "moved sendTraceTitle next to restoreInitialtables"
WangJialin547 7142ba1
used widgets and flexible style and pruned unneccessary styles
WangJialin547 fb50c6d
format code
WangJialin547 d78a5fd
change trace_processsor_id to camelCase
WangJialin547 4e4bd17
removed unneccessary undefined handling in http_rpc_engine.ts constru…
WangJialin547 d3ac67b
utilize classNames utility
WangJialin547 fa8db57
improved generic css class names to specific ones, e.g. pf-rpc-http-d…
WangJialin547 0ee49a9
ui: Allow any key-value pairs to be passed to (most) widgets (#3062)
stevegolton a9e8392
removed unneccessary Card as unknown as string after implementing #3062
WangJialin547 ae14898
shows 'New Instance...' if there are no traces loaded for consistency
WangJialin547 0842f5a
removed unneccessary try catch clause
WangJialin547 7718086
added copyright header to preloaded_trace_dialog.scss
WangJialin547 dc54dc9
deleted 'strong' inside the cards
WangJialin547 2373afd
combined the x button with the stack
WangJialin547 ab597cb
removed keyboard ux
WangJialin547 eee44e7
removed side effects of useRpcWithPreloadedtrace and returns everything
WangJialin547 0522b9f
clicking the cards will now directly connect to the respective instance
WangJialin547 493fbf1
updated modal
WangJialin547 5a0a30f
deleted preloaded_trace_dialog and uses default Card widget style
WangJialin547 29f15ca
removed the deleted file from perfetto.scss
WangJialin547 1c48959
changed null to undefined
WangJialin547 3cf6d9d
format code
WangJialin547 8313745
changed integer instance IDs to string UUIDs
WangJialin547 057a2be
format code
WangJialin547 e6b97ed
attempt to address back comp issues
WangJialin547 e52992e
Merge remote-tracking branch 'upstream/main'
WangJialin547 cce0452
pulled recent additions and made changes accordingly
WangJialin547 3336585
bug fix
WangJialin547 f7623b2
fix presubmit issues
WangJialin547 a70bf6e
loaded the trace_processor_shell instance onto a separate thread
WangJialin547 711fa11
solved autoreconnection issue by keep track of uuids of closed connec…
WangJialin547 d885b99
fixed backcomp issues
WangJialin547 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove the .