Skip to content

fix(gitter): better traffic handling and patch ID caching#5211

Merged
Ly-Joey merged 5 commits intogoogle:masterfrom
Ly-Joey:fix-gitter-patch-ID
Apr 9, 2026
Merged

fix(gitter): better traffic handling and patch ID caching#5211
Ly-Joey merged 5 commits intogoogle:masterfrom
Ly-Joey:fix-gitter-patch-ID

Conversation

@Ly-Joey
Copy link
Copy Markdown
Contributor

@Ly-Joey Ly-Joey commented Apr 8, 2026

Makes 2 changes to gitter traffic handling and Patch ID calculation:

  1. If context cancels in the middle of loadRepository(), patch ID calculated so far will be saved so we don't need to redo them next time
  2. Move semaphore acquisition into singleflight
    This means affected commit graph walking will not have concurrency limit, but I think (hope?) graph walking is fast enough once a repo is loaded.

@Ly-Joey Ly-Joey changed the title fix(gitter): save calculated patch ID to cache if context cancels fix(gitter): better handling for patch ID calculation when there's traffic Apr 8, 2026
@Ly-Joey Ly-Joey changed the title fix(gitter): better handling for patch ID calculation when there's traffic fix(gitter): better traffic handling and patch ID caching Apr 8, 2026
@Ly-Joey Ly-Joey marked this pull request as ready for review April 8, 2026 21:02
@Ly-Joey Ly-Joey requested a review from another-rex April 8, 2026 21:03
another-rex
another-rex previously approved these changes Apr 9, 2026
@Ly-Joey Ly-Joey enabled auto-merge (squash) April 9, 2026 03:00
@Ly-Joey Ly-Joey merged commit 74c64f4 into google:master Apr 9, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants