Skip to content

fix Rngs.__getattr__ returning default stream for dunder names (#5375) #5379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohsinm-dev wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

fix Rngs.__getattr__ returning default stream for dunder names (#5375) #5379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions flax/nnx/rnglib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,8 @@ def __getitem__(self, name: str):
return self._get_stream(name, KeyError)

def __getattr__(self, name: str):
if name.startswith('__') and name.endswith('__'):
raise AttributeError(name)
return self._get_stream(name, AttributeError)

def __call__(self):
Expand Down
10 changes: 10 additions & 0 deletions tests/nnx/rngs_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,5 +421,15 @@ def test_with_rngs_broadcast(self, graph):
self.assertEqual(new_rngs_mapped['dropout'].key.shape, ())


def test_dunder_raises_attribute_error(self):
rngs = nnx.Rngs(default=42)
with self.assertRaises(AttributeError):
_ = rngs.__pydantic_serializer__
with self.assertRaises(AttributeError):
_ = rngs.__totally_fake__
with self.assertRaises(AttributeError):
_ = rngs.__json__


if __name__ == '__main__':
absltest.main()