Validate filamesh buffer bounds in MeshReader#9910
Open
TristanInSec wants to merge 1 commit intogoogle:mainfrom
Open
Validate filamesh buffer bounds in MeshReader#9910TristanInSec wants to merge 1 commit intogoogle:mainfrom
TristanInSec wants to merge 1 commit intogoogle:mainfrom
Conversation
7 tasks
Author
|
Hi, friendly ping on this PR. Let me know if any changes are needed. Thanks! |
Add a dataSize parameter to loadMeshFromBuffer and validate all header fields against the buffer boundary before advancing the parse pointer. Also check for multiplication overflow in the compressed index and vertex buffer size calculations. Update all callers to pass the buffer size.
TristanInSec
force-pushed
the
validate-filamesh-input
branch
from
9bc07f4 to
943f977
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataSizeparameter toloadMeshFromBufferto enable bounds validationvertexSize,indexSize,parts,materialCount,nameLength) against the buffer boundary before advancing the parse pointerfd < 0check inloadMeshFromFileTest plan
test_filameshtests pass (both NonInterleaved and Interleaved).filameshfiles return empty Mesh instead of reading past the buffer