Stencil support for VK backend#9888
Merged
jorgeag-google merged 1 commit intogoogle:mainfrom Apr 22, 2026
Merged
Conversation
Contributor
|
@jorgeag-google , would you mind being more descriptive on why this change is necessary? (in the commit message, but then you'll have to copy the commit message over to the PR description). |
jorgeag-google
force-pushed
the
vk_stencil
branch
2 times, most recently
from
df18337 to
abcac7a
Compare
poweifeng
reviewed
Apr 13, 2026
jorgeag-google
force-pushed
the
vk_stencil
branch
3 times, most recently
from
96bc2b7 to
628fb1b
Compare
poweifeng
reviewed
Apr 15, 2026
rafadevai
reviewed
Apr 15, 2026
rafadevai
reviewed
Apr 15, 2026
rafadevai
reviewed
Apr 15, 2026
jorgeag-google
force-pushed
the
vk_stencil
branch
2 times, most recently
from
6b73d16 to
1d0fa49
Compare
rafadevai
reviewed
Apr 21, 2026
rafadevai
reviewed
Apr 21, 2026
rafadevai
reviewed
Apr 21, 2026
rafadevai
reviewed
Apr 21, 2026
rafadevai
reviewed
Apr 21, 2026
jorgeag-google
force-pushed
the
vk_stencil
branch
from
1d0fa49 to
9a0191a
Compare
rafadevai
approved these changes
Apr 21, 2026
poweifeng
approved these changes
Apr 22, 2026
jorgeag-google
force-pushed
the
vk_stencil
branch
2 times, most recently
from
b535f51 to
5ce1f8f
Compare
In order to support stencil op in VK we need to: 1)Configure corresponding pipeline/render pass 2)Configure attachment/FB Previous PR (google#9716) covers 1) This PR covers 2) This PR also makes the the following tests pass on VK BasicStencilBufferTest.StencilBuffer BasicStencilBufferTest.DepthAndStencilBuffer
jorgeag-google
force-pushed
the
vk_stencil
branch
from
5ce1f8f to
f0f0923
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stencil support for VK backend
In order to support stencil op in VK we need to:
Previous PR (#9716) covers 1)
This PR covers 2)
This PR also makes the the following tests pass on VK