Match interfaces that override equals in ReferenceEquality#5683
Merged
copybara-service[bot] merged 1 commit intomasterfrom Mar 31, 2026
Merged
Match interfaces that override equals in ReferenceEquality#5683copybara-service[bot] merged 1 commit intomasterfrom
equals in ReferenceEquality#5683copybara-service[bot] merged 1 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test_892252608
branch
2 times, most recently
from
90319f4 to
a693253
Compare
If an interface specifies behaviour of `equals`, `ReferenceEquality` should suggest using `equals` for implementations of the interface even if it can't guarantee there's a concrete implementation of equals. For example, interfaces like `List` and `MemorySegment` specify behaviour for equals. PiperOrigin-RevId: 892346252
copybara-service
bot
force-pushed
the
test_892252608
branch
from
a693253 to
429a509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match interfaces that override
equalsinReferenceEqualityIf an interface specifies behaviour of
equals,ReferenceEqualityshould suggest usingequalsfor implementations of the interface even if it can't guarantee there's a concrete implementation of equals.For example, interfaces like
ListandMemorySegmentspecify behaviour for equals.