Repository navigation
Note agy (Antigravity) 1.4.10 prefix completion in the README - #230
Conversation
Keep the /egm: prefix instruction for Antigravity and Claude Code, and note that agy CLI 1.4.10 completes unprefixed names to the prefixed command (tested interactively in google#220). Regenerate distributions/claude/README.md with scripts/pack_plugin.py so the published Claude runtime matches the source README. Closes google#220
n3wth
left a comment
There was a problem hiding this comment.
Reviewed 1585b99. Both files end up with the same line 52 (the diff shows the same blob, 2d3bae8, for each), which is what test_published_claude_runtime_is_current compares. The packaged copy was also stale from before #208, so regenerating it is the right fix. The #220 comment supports the 1.4.10 behavior, and #196 shows unprefixed names failing on 1.4.8.
One non-blocking wording suggestion inline.
#209 edits the same line in distributions/claude/README.md, so it will conflict once this merges, as the description already notes.
I did not run the unit tests; the 138 passed in the description is the author's run. cla/google and the scope/template check pass; the Tests workflow has not run on this head.
Nothing blocking.
Co-authored-by: n3wth <5912894+n3wth@users.noreply.github.com>
Co-authored-by: n3wth <5912894+n3wth@users.noreply.github.com>
n3wth
left a comment
There was a problem hiding this comment.
Re-reviewed at c210baf. The only change since 1585b99 is the wording suggestion from my last round, applied to both files. README.md and distributions/claude/README.md now resolve to the same blob (13e4779), which is what test_published_claude_runtime_is_current compares. The text keeps /egm: as the rule, says 1.4.10 completes an unprefixed name and 1.4.8 does not, and links #220 and #196.
I ran tests/unit locally at this head: 138 passed. The Tests workflow has not run on this head; cla/google and the scope/template check pass.
#209 edits the same line in distributions/claude/README.md, so whichever lands second needs a regenerate, as the description already notes.
No remaining finding.
|
Hi @n3wth , Thanks for the re-review! A few related gaps I noticed while testing, outside this PR's scope:
This PR also includes #209's packaged README sync, so #209 shouldn't be needed once this merges. |
|
Please send the small follow-up PR for Keep the 1.4.10 invocation result separate from the full workflow results. Do not replace the 1.4.5 workflow record with an invocation-only result. A full fixture run on 1.4.10 would help. If you run it, record the EGM commit, host version, commands, and results. Keep the Antigravity IDE result unverified until a separate test covers it. |
Contribution Type
Please select the track that matches this pull request:
skills/oragents/; no design doc required)Refs #___withdesign-ready| Addsdocs/designs/<name>.mdand updatesdocs/designs/README.md; useRefsinstead ofClosesso the issue stays open for Stage 2)Closes #___withpr-ready| Implements mergeddocs/designs/<name>.md)Summary of Key Changes
Closes #220.
README.mdline 52: keeps the/egm:prefix instruction for Antigravity (agy CLI) and Claude Code, and adds that agy CLI 1.4.10 completes an unprefixed name to the prefixed command, linking Verify the /egm: prefix in the interactive Antigravity CLI #220. The prefix stays the instruction because README: Antigravity (agy CLI) also requires the /egm: prefix for skills #196 saw unprefixed names fail on 1.4.8.distributions/claude/README.md: regenerated withpython3 scripts/pack_plugin.py --target claude --output <dir>and replaced with the generatedegm-claudefolder. OnlyREADME.mdchanged. This also carries over docs: note Antigravity (agy CLI) also requires /egm: prefix #208's earlier README edit, sotest_published_claude_runtime_is_currentpasses. It touches the same line as fix(packaging): sync the packaged readme #209; if fix(packaging): sync the packaged readme #209 merges first, I'll regenerate again./egm:menu,/egm-brainstorm,/egm-review,/egm-draft,/egm-nonexistent).Not changed here:
docs/getting_started.mdand the website still show unprefixed commands without prefix guidance, TESTING.md's Antigravity row still records 1.4.5, and the Antigravity IDE was not tested.Human Accountability Affirmation
Verification
/egm-review docs/designs/<name>.md, resolved findings via/egm-resolve, and verified relative links (pytest tests/unit/test_link_integrity.py).test_scenarios.yamladded/updated andpytest tests/unitexecuted./egm-brainstorm,/egm-draft, and/egm-reviewon the target harness; attached execution summary or transcript.Docs-only change; no test change needed.
pytest tests/unit: 138 passed.