Repository navigation
Show the Claude runtime regeneration command - #225
Conversation
n3wth
left a comment
There was a problem hiding this comment.
Reviewed da7649e. The command is correct: --target and --output are both required by pack_plugin.py, and the builder writes <output>/egm-claude. One wording fix inline, non-blocking.
The PR only changes the assertion message, so I did not run the tests. The new text is reachable only while test_published_claude_runtime_is_current fails, which it does on main until #209 lands, and I did not trigger that failure to print the message. cla/google and the scope/template check pass; the Tests workflow has not run on this head.
n3wth
left a comment
There was a problem hiding this comment.
Re-reviewed at 67ab9de. The only change since da7649e is the wording fix from my last round: the message now uses python3 and says to replace distributions/claude with the generated egm-claude folder, which matches docs/directory.md and avoids leaving stale files behind.
I ran tests/unit locally at this head. The one failure is test_published_claude_runtime_is_current, from the README.md drift that #209 fixes, and it prints the new message as written. The Tests workflow has not run on this head; cla/google and the scope/template check pass.
Nothing blocking.
Refs #219
Contribution Type
Summary of Key Changes
python3 scripts/pack_plugin.py --target claude --output <output-dir>.egm-claudefolder should replacedistributions/claude, preventing stale files from remaining.Suggested label:
ci.Human Accountability Affirmation
Verification
For Design Doc PRs (Stage 1): Not applicable.
For Bug Fix / Implementation PRs (Stage 2): Executed unit tests; details below.
For Harness Support PRs: Not applicable.
pytest tests/unit -k 'not published_claude_runtime_is_current'passes on currentmain.The full suite passes when the generated Claude README sync from fix(packaging): sync the packaged readme #209 is applied temporarily. fix(packaging): sync the packaged readme #209 is still open, so the unchanged
test_published_claude_runtime_is_currentfailure remains on currentmainuntil that fix lands; the focused run confirms this PR now prints the full regeneration command and replacement guidance.git diff --checkpasses.