Skip to content

Run both unit test jobs after a failure - #224

Open
n3wth wants to merge 2 commits into
mainfrom
ci/tests-keep-matrix-running
Open

Run both unit test jobs after a failure#224
n3wth wants to merge 2 commits into
mainfrom
ci/tests-keep-matrix-running

Conversation

@n3wth

@n3wth n3wth commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Contribution Type

  • Bug Fix / Minor Patch
  • Feature / Architectural Change -- Stage 1: Design Doc PR
  • Feature / Architectural Change -- Stage 2: Implementation PR

Summary of Key Changes

Set fail-fast: false on the unit-test matrix. A failed job no longer cancels the other OS job. Both jobs report independent results.

This PR changes one workflow line. The shared generated-runtime failure is fixed on main. #209 is closed as superseded.

Human Accountability Affirmation

  • I am a human contributor. I have personally reviewed, understood, and can explain every line of this change in review (using AI tools to write code is welcome, but human understanding of the submitted change is required).

Verification

  • For Design Doc PRs (Stage 1): Not applicable.
  • For Bug Fix / Implementation PRs (Stage 2): Ran the full existing unit suite. This configuration needs no new unit test.
  • For Harness Support PRs: Not applicable.

Head 409c4a20701b23f80a5a0147ee00f1c482054dc6 passed 138 local tests. Fresh Linux and Windows jobs passed. Workflow-security, CLA, and diff whitespace checks passed. Code-owner review remains required.

@n3wth
ci(tests): keep both unit jobs running when one fails
2b2928c 
The unit matrix used the default fail-fast, so a failure on Ubuntu cancelled
the Windows job. The check then read cancelled instead of failed. Set
fail-fast to false so each operating system reports its own result.
@n3wth n3wth added the ci Pull requests that update GitHub Actions code label Oct 29, 2026
@n3wth
n3wth enabled auto-merge (squash) October 29, 2026 10:23
@n3wth n3wth mentioned this pull request Oct 29, 2026
Open
2 of 7 tasks
recursivethinker
recursivethinker approved these changes Oct 29, 2026
View reviewed changes

@recursivethinker recursivethinker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@n3wth

n3wth commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Merged the then-current main and repeated validation. All 138 local tests, both OS jobs, and workflow-security checks passed. The diff still contains only the one-line fail-fast change.

Approval from another listed code owner remains required. The existing collaborator approval does not satisfy that rule.

This was referenced Oct 30, 2026
Open
Open
@n3wth n3wth changed the title ci(tests): keep both unit jobs running when one fails Keep both unit test jobs running when one fails Oct 30, 2026
@n3wth n3wth changed the title Keep both unit test jobs running when one fails Run both unit test jobs after a failure Oct 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@recursivethinker recursivethinker recursivethinker approved these changes
@briansuchy briansuchy Awaiting requested review from briansuchy briansuchy is a code owner
@quinnjim quinnjim Awaiting requested review from quinnjim quinnjim is a code owner
@drensin drensin Awaiting requested review from drensin drensin is a code owner
@tearseb tearseb Awaiting requested review from tearseb tearseb is a code owner
@eewing314 eewing314 Awaiting requested review from eewing314 eewing314 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ci Pull requests that update GitHub Actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@n3wth @recursivethinker