Model pass through behavior of our ArgCaptureAbortIf* support functions#863
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 23, 2026
Merged
Model pass through behavior of our ArgCaptureAbortIf* support functions#863copybara-service[bot] merged 1 commit intomainfrom
ArgCaptureAbortIf* support functions#863copybara-service[bot] merged 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_902635618
branch
2 times, most recently
from
943fca2 to
3b0e62f
Compare
…ions
Otherwise, we it looks like the return of those `ArgCaptureAbortIf*` get checked, but not the original inputs, and we end up accidentally inferring Nullable for the return of `Target` in this case:
```
int* _Nullable Get(int x);
int* Target() {
int* _Nullable p = Get(-1);
CHECK(p != nullptr);
return p;
}
```
PiperOrigin-RevId: 904443703
copybara-service
Bot
force-pushed
the
test_902635618
branch
from
3b0e62f to
18d4069
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model pass through behavior of our
ArgCaptureAbortIf*support functionsOtherwise, we it looks like the return of those
ArgCaptureAbortIf*get checked, but not the original inputs, and we end up accidentally inferring Nullable for the return ofTargetin this case: