This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Expose a callback when no cameras are detected. - #102
Open
mkotyk wants to merge 2 commits into
Open
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
Author
|
Trov signed it! |
|
Looks good, the only addition I would make is to call |
added 2 commits
June 9, 2017 09:23
- Fix crashes related to no camera (tested in emulator)
|
CLAs look good, thanks! |
WayLoCode
pushed a commit
to WayLoCode/cameraview
that referenced
this pull request
Jul 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of throwing a Runtime exception, this patch exposes a callback to indicate there were no cameras enumerated. Tested using emulator.