Merged
Conversation
Collaborator
|
The change itself looks good, but can you please split the F16 fixes into a separate PR? They seem unrelated to the cooperative matrix change itself. |
ArberSephirotheca
force-pushed
the
cooperative-matrix
branch
from
d452116 to
48f54b3
Compare
ArberSephirotheca
changed the title
Contributor
Author
|
Make sense, I split the f16 fix into a separate PR #1112 . This PR now only contains the cooperative matrix feature support. |
dj2
approved these changes
Apr 15, 2026
Collaborator
|
Sorry, Github did something I didn't expect when it force-pushed the rebase. Hopefully once the bots run again this should land. |
Collaborator
|
And merged, thank you very much for the patch and the iteration, it's greatly appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Amber could not request/enable
VkPhysicalDeviceCooperativeMatrixFeaturesKHR::cooperativeMatrixfrom AmberScript.This PR add AmberScript support for
DEVICE_FEATURE CooperativeMatrixFeaturesKHR.cooperativeMatrix