(Lit) Add missing features to ChoicePicker and CheckBox#1145
Merged
ditman merged 5 commits intogoogle:mainfrom Apr 14, 2026
Merged
(Lit) Add missing features to ChoicePicker and CheckBox#1145ditman merged 5 commits intogoogle:mainfrom
ditman merged 5 commits intogoogle:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request restructures the Lit renderer for version 0.9.0 by introducing a BasicCatalogA2uiLitElement base class and migrating component styles from inline definitions to static CSS blocks. The changes include the removal of the minimalCatalog in favor of an expanded basicCatalog, updated test infrastructure, and enhanced component features such as filtering in the ChoicePicker. Feedback identifies a layout issue with the horizontal Divider, documentation discrepancies in the ChoicePicker and Image components, and opportunities to improve accessibility and CSS variable fallbacks.
renderers/lit/src/v0_9/catalogs/basic/components/ChoicePicker.ts
Outdated
Show resolved
Hide resolved
ditman
force-pushed
the
core-styling-choicepicker-chips
branch
2 times, most recently
from
db9ad08 to
5398410
Compare
ditman
force-pushed
the
core-styling-choicepicker-chips
branch
from
5398410 to
2305f4b
Compare
jacobsimionato
approved these changes
Apr 14, 2026
ditman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following missing features to the Lit renderer:
It also adds some unit tests to the specific behavior of the components (which should be expanded with more tests for other components later!)
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.