(Lit) Style widgets using CSS variables. #1079
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { ComponentApi } from "@a2ui/web_core/v0_9"; | ||
| import { A2uiLitElement } from "../../a2ui-lit-element.js"; | ||
| import { injectBasicCatalogStyles } from "@a2ui/web_core/v0_9/basic_catalog"; | ||
|
|
||
| /** | ||
| * A base class for A2UI basic catalog components. | ||
| * | ||
| * Handles some common features of all basic catalog A2ui elements, like | ||
| * injecting the basic CSS styles if needed, and setting the flex property | ||
| * if set by the framework. | ||
| */ | ||
| export abstract class BasicCatalogA2uiLitElement< | ||
| Api extends ComponentApi, | ||
| > extends A2uiLitElement<Api> { | ||
| connectedCallback() { | ||
| super.connectedCallback(); | ||
| injectBasicCatalogStyles(); | ||
| } | ||
|
|
||
| updated(changedProperties: Map<PropertyKey, unknown>) { | ||
| super.updated(changedProperties); | ||
| const props = this.controller?.props as any; | ||
| if (props && props.weight !== undefined) { | ||
| this.style.flex = String(props.weight); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,13 +14,37 @@ | |
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { html, nothing, css } from "lit"; | ||
| import { customElement } from "lit/decorators.js"; | ||
| import { CardApi } from "@a2ui/web_core/v0_9/basic_catalog"; | ||
| import { BasicCatalogA2uiLitElement } from "../basic-catalog-a2ui-lit-element.js"; | ||
| import { A2uiController } from "@a2ui/lit/v0_9"; | ||
|
|
||
| @customElement("a2ui-card") | ||
| export class A2uiCardElement extends BasicCatalogA2uiLitElement<typeof CardApi> { | ||
| /** | ||
| * The styles of the card can be customized by redefining the following | ||
| * CSS variables: | ||
| * | ||
| * - `--a2ui-card-border`: The styling for the card border. Defaults to `--a2ui-border-width` width and `--a2ui-color-border` color. | ||
| * - `--a2ui-card-border-radius`: The border radius of the card. Defaults to `--a2ui-border-radius`. | ||
| * - `--a2ui-card-padding`: The padding of the card. Defaults to `--a2ui-spacing-m`. | ||
| * - `--a2ui-card-box-shadow`: The box shadow of the card. Defaults to `0 2px 4px rgba(0,0,0,0.1)`. | ||
| * - `--a2ui-card-margin`: The outer margin of the card. Defaults to `--a2ui-spacing-m`. | ||
| */ | ||
| static styles = css` | ||
| :host { | ||
| display: block; | ||
| border: var(--a2ui-card-border, var(--a2ui-border-width, 1px) solid var(--a2ui-color-border, #ccc)); | ||
| border-radius: var(--a2ui-card-border-radius, var(--a2ui-border-radius, 8px)); | ||
| padding: var(--a2ui-card-padding, var(--a2ui-spacing-m, 16px)); | ||
| background: var(--a2ui-card-background, var(--a2ui-color-surface, #fff)); | ||
| color: var(--a2ui-color-on-surface, #333); | ||
| box-shadow: var(--a2ui-card-box-shadow, 0 2px 4px rgba(0,0,0,0.1)); | ||
| margin: var(--a2ui-card-margin, var(--a2ui-spacing-m)); | ||
| } | ||
| `; | ||
|
|
||
| protected createController() { | ||
| return new A2uiController(this, CardApi); | ||
| } | ||
|
|
@@ -30,12 +54,7 @@ export class A2uiCardElement extends A2uiLitElement<typeof CardApi> { | |
| if (!props) return nothing; | ||
|
|
||
| return html` | ||
| ${props.child ? html`${this.renderNode(props.child)}` : nothing} | ||
| `; | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,13 +14,55 @@ | |
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { html, nothing, css } from "lit"; | ||
| import { customElement } from "lit/decorators.js"; | ||
| import { classMap } from "lit/directives/class-map.js"; | ||
| import { CheckBoxApi } from "@a2ui/web_core/v0_9/basic_catalog"; | ||
| import { BasicCatalogA2uiLitElement } from "../basic-catalog-a2ui-lit-element.js"; | ||
| import { A2uiController } from "@a2ui/lit/v0_9"; | ||
|
|
||
| @customElement("a2ui-checkbox") | ||
| export class A2uiCheckBoxElement extends BasicCatalogA2uiLitElement<typeof CheckBoxApi> { | ||
| /** | ||
| * The styles of the checkbox can be customized by redefining the following | ||
| * CSS variables: | ||
| * | ||
| * - `--a2ui-checkbox-size`: Size of the box. Defaults to `1rem`. | ||
| * - `--a2ui-checkbox-border-radius`: Default corner rounding of the box. | ||
| * - `--a2ui-checkbox-gap`: Spacing between the checkbox and its label. Defaults to `8px`. | ||
| * - `--a2ui-checkbox-margin`: Outer margin of the component. Defaults to `--a2ui-spacing-m`. | ||
| * - `--a2ui-checkbox-color-error`: Color for invalid state. Defaults to `red`. | ||
| * - `--a2ui-checkbox-label-font-size`: Font size of the label. Defaults to `--a2ui-label-font-size` then `--a2ui-font-size-s`. | ||
| * - `--a2ui-checkbox-label-font-weight`: Font weight of the label. Defaults to `--a2ui-label-font-weight` then `bold`. | ||
| */ | ||
| static styles = css` | ||
| :host { | ||
| display: inline-block; | ||
| margin: var(--a2ui-checkbox-margin, var(--a2ui-spacing-m)); | ||
| } | ||
| label.a2ui-checkbox { | ||
| display: inline-flex; | ||
| align-items: center; | ||
| gap: var(--a2ui-checkbox-gap, var(--a2ui-spacing-s, 0.5rem)); | ||
| font-size: var(--a2ui-checkbox-label-font-size, var(--a2ui-label-font-size, var(--a2ui-font-size-s))); | ||
| font-weight: var(--a2ui-checkbox-label-font-weight, var(--a2ui-label-font-weight, bold)); | ||
| cursor: pointer; | ||
| } | ||
| label.invalid { | ||
| color: var(--a2ui-checkbox-color-error, red); | ||
| } | ||
| input { | ||
| width: var(--a2ui-checkbox-size, 1rem); | ||
| height: var(--a2ui-checkbox-size, 1rem); | ||
| background: var(--a2ui-checkbox-background, inherit); | ||
| border: var(--a2ui-checkbox-border, var(--a2ui-border)); | ||
ditman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| border-radius: var(--a2ui-checkbox-border-radius, 4px); | ||
| } | ||
| input.invalid { | ||
| outline: 1px solid var(--a2ui-checkbox-color-error, red); | ||
| } | ||
| `; | ||
|
|
||
| protected createController() { | ||
| return new A2uiController(this, CheckBoxApi); | ||
| } | ||
|
|
@@ -29,10 +71,15 @@ export class A2uiCheckBoxElement extends A2uiLitElement<typeof CheckBoxApi> { | |
| const props = this.controller.props; | ||
| if (!props) return nothing; | ||
|
|
||
| const isInvalid = props.isValid === false; | ||
| const labelClasses = { "a2ui-checkbox": true, invalid: isInvalid }; | ||
| const inputClasses = { invalid: isInvalid }; | ||
|
|
||
| return html` | ||
| <label class=${classMap(labelClasses)}> | ||
| <input | ||
| type="checkbox" | ||
| class=${classMap(inputClasses)} | ||
| .checked=${props.value || false} | ||
| @change=${(e: Event) => | ||
| props.setValue?.((e.target as HTMLInputElement).checked)} | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
weightproperty is applied to the host'sflexstyle, but it is never reset if the property is removed from the component's props. This can lead to unexpected layout behavior if the weight is dynamically changed toundefined.