Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for processing batches of messages in the v0.9 protocol. It adds new schemas and interfaces for message lists (both client-to-server and server-to-client), implements a processPayload method in the MessageProcessor to handle both single messages and lists, and includes unit tests for these changes. The review feedback focuses on maintaining protocol consistency by ensuring that the new message list structures include a version field, similar to other top-level messages.
renderers/web_core/src/v0_9/processing/message-processor.test.ts
Outdated
Show resolved
Hide resolved
jacobsimionato
left a comment
jacobsimionato
left a comment
There was a problem hiding this comment.
Approval pending resolving one nit!
| }) | ||
| .strict(); | ||
|
|
||
| export declare interface A2uiClientMessageList extends z.infer<typeof A2uiClientMessageListSchema> { |
There was a problem hiding this comment.
This declaration doesn't match the rest of the file - can we just do:
export type A2uiClientMessageList = z.infer<typeof A2uiClientMessageListSchema>;
?
I think may be we don't need the declaration for client-to-server because we don't validate?
2 participants
add interfaces for schema change
#1055