Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive glossary of terms for the A2UI protocol and general Generative UI concepts, while also updating existing documentation for consistency and linking the overview to the new glossary. The review feedback focuses on refining the glossary by addressing minor typographical and grammatical errors, ensuring consistent terminology (e.g., using 'renderer' and 'agent' consistently), and requesting a missing link for external references.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
wrenj
left a comment
There was a problem hiding this comment.
approved, thanks for workign on this!
docs/glossary.md
Outdated
|
|
||
|  | ||
|
|
||
| While the protocol is designed for **AI-empowered agents**, it can work with deterministic agents as well. For example, an agent that tests the renderer, may be noAI-agent. |
There was a problem hiding this comment.
For example, an MCP server may return a pre-canned A2UI UI.
There was a problem hiding this comment.
Removed testing case, added 'pre-canned A2UI UI'.
But added note about MCP and A2A to the section 'Agent architecture'.
docs/glossary.md
Outdated
|
|
||
| Pieces of generated UI are shown one by one, with the goal to collect necessary information for a certain task. | ||
|
|
||
| ### NoAI information |
There was a problem hiding this comment.
this is new to me, is this common term?
There was a problem hiding this comment.
I introduced this term in response to user requests. I do not know about prior art for exactly this type of data category. This is prior art for similar concept: https://no-ai-icon.com/
|
|
||
| Terms, required by A2UI protocol. | ||
|
|
||
| ### A2UI agent and A2UI renderer |
There was a problem hiding this comment.
we should to rename the json files here for v.10
https://github.com/google/A2UI/blob/main/specification/v0_10/json
client -> renderer
server -> agent
There was a problem hiding this comment.
I am afraid to break something by simply renaming.
Created issue: #1072
Closes #713