-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: improve MCP Apps integration guide with step-by-step walkthrough #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zeroasterisk
wants to merge
4
commits into
google:main
Choose a base branch
from
zeroasterisk:improve-mcp-apps-guide
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+134
−27
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4109888
docs: improve MCP Apps integration guide with step-by-step walkthrough
zeroasterisk 88f50f6
fix: correct default ports and add missing renderer build step
zeroasterisk 938190f
fix: add --include=dev for npm install, Angular 21 host troubleshooting
zeroasterisk 80855cc
docs: add MCP Calculator demo GIF to guide
zeroasterisk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linked Lit example (
mcp-apps-component.ts) contains two discrepancies with the security model described in this guide:sandboxattribute withallow-same-origin(line 79 of that file).allow-same-origin(lines 19 and 27). However, the Lit component explicitly includes it when callingsendSandboxResourceReady(line 179 of that file).These should be corrected in the sample code to ensure it serves as a secure and consistent reference implementation. The Angular example (
mcp-app.ts) correctly follows these principles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — verified this is a real issue.
Angular sample correctly passes
sandbox: 'allow-scripts'tosendSandboxResourceReady()(line ~89 ofmcp-app.ts), so the inner iframe ends up with onlyallow-scripts.Lit sample passes
sandbox: 'allow-scripts allow-forms allow-popups allow-modals allow-same-origin'(line ~179 ofmcp-apps-component.ts), which violates the guide's security model.Additionally:
sandbox="allow-scripts allow-forms allow-popups allow-modals allow-same-origin"(line 79) — the guide says the proxy iframe should not be sandboxed.sandbox.ts(line 66) sets an initial default ofallow-scripts allow-same-origin allow-formson the inner iframe beforesendSandboxResourceReadyoverrides it — this means there's a brief window where the inner iframe hasallow-same-origin.This is a docs PR so fixing the Lit sample code is out of scope here, but it should be filed as a separate issue. The guide's security model description is correct — the Lit sample doesn't follow it.