Address additional feedback

Author: OwenScott-GDS

README.md

@@ -4,14 +4,14 @@ Solution code for the Android Basics with Compose: Reply app.
 
 Introduction
 ------------
-The Reply app is a simple email client that display various categories of your
-inbox. This app is used to illustrate the concept of adaptive layout.
+The Reply app is a basic email client that displays various categories of your
+inbox. This app is used to illustrate the concept of adaptive layouts.
 
 Pre-requisites
 --------------
 
-* Experience with Kotlin syntax.
-* How to create and run a project in Android Studio.
+* Experience with Kotlin syntax
+* How to create and run a project in Android Studio
 * How to create composable functions
 * How to create compose navigation
 

app/src/main/AndroidManifest.xml

@@ -39,4 +39,4 @@
         </activity>
     </application>
 
-</manifest>
+</manifest>

app/src/main/java/com/example/reply/ui/ReplyDetailsScreen.kt

@@ -154,7 +154,9 @@ private fun ReplyEmailDetailsCard(
                 email,
                 Modifier.fillMaxWidth()
             )
-            if (!isFullScreen) {
+            if (isFullScreen) {
+                Spacer(modifier = Modifier.height(dimensionResource(R.dimen.detail_content_padding_top)))
+            } else {
                 Text(
                     text = stringResource(email.subject),
                     style = MaterialTheme.typography.bodyMedium,
@@ -164,8 +166,6 @@ private fun ReplyEmailDetailsCard(
                         bottom = dimensionResource(R.dimen.detail_expanded_subject_body_spacing)
                     ),
                 )
-            } else {
-                Spacer(modifier = Modifier.height(dimensionResource(R.dimen.detail_content_padding_top)))
             }
             Text(
                 text = stringResource(email.body),
@@ -298,10 +298,10 @@ private fun ActionButton(
         ) {
             Text(
                 text = text,
-                color = if (!containIrreversibleAction) {
-                    MaterialTheme.colorScheme.onSurfaceVariant
-                } else {
+                color = if (containIrreversibleAction) {
                     MaterialTheme.colorScheme.onError
+                } else {
+                    MaterialTheme.colorScheme.onSurfaceVariant
                 }
             )
         }

app/src/main/java/com/example/reply/ui/ReplyHomeScreen.kt

@@ -188,8 +188,7 @@ private fun ReplyAppContent(
                 AnimatedVisibility(
                     visible = navigationType == ReplyNavigationType.BOTTOM_NAVIGATION
                 ) {
-                    val bottomNavigationContentDescription =
-                        stringResource(R.string.navigation_bottom)
+                    val bottomNavigationContentDescription = stringResource(R.string.navigation_bottom)
                     ReplyBottomNavigationBar(
                         currentTab = replyUiState.currentMailbox,
                         onTabPressed = onTabPressed,

app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml

@@ -18,4 +18,4 @@
     <background android:drawable="@drawable/ic_launcher_background" />
     <foreground android:drawable="@drawable/ic_launcher_foreground" />
     <monochrome android:drawable="@drawable/ic_launcher_foreground" />
-</adaptive-icon>
+</adaptive-icon>

app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml

@@ -18,4 +18,4 @@
     <background android:drawable="@drawable/ic_launcher_background" />
     <foreground android:drawable="@drawable/ic_launcher_foreground" />
     <monochrome android:drawable="@drawable/ic_launcher_foreground" />
-</adaptive-icon>
+</adaptive-icon>

app/src/main/res/values/strings.xml

@@ -36,47 +36,47 @@
 
     <string name="account_1_first_name">Jeff</string>
     <string name="account_1_last_name">Hansen</string>
-    <string name="account_1_email">hikingfan@gmail.com</string>
+    <string name="account_1_email">hikingfan@altostrat.com</string>
 
     <string name="account_4_first_name">Tracy</string>
     <string name="account_4_last_name">Alvarez</string>
-    <string name="account_4_email">tracealvie@gmail.com</string>
+    <string name="account_4_email">tracealvie@altostrat.com</string>
 
     <string name="account_5_first_name">Allison</string>
     <string name="account_5_last_name">Trabucco</string>
-    <string name="account_5_email">atrabucco222@gmail.com</string>
+    <string name="account_5_email">atrabucco222@altostrat.com</string>
 
     <string name="account_6_first_name">Ali</string>
     <string name="account_6_last_name">Connors</string>
-    <string name="account_6_email">aliconnors@gmail.com</string>
+    <string name="account_6_email">aliconnors@altostrat.com</string>
 
     <string name="account_7_first_name">Alberto</string>
     <string name="account_7_last_name">Williams</string>
-    <string name="account_7_email">albertowilliams124@gmail.com</string>
+    <string name="account_7_email">albertowilliams124@altostrat.com</string>
 
     <string name="account_8_first_name">Kim</string>
     <string name="account_8_last_name">Alen</string>
-    <string name="account_8_email">alen13@gmail.com</string>
+    <string name="account_8_email">alen13@altostrat.com</string>
 
     <string name="account_9_first_name">Google</string>
     <string name="account_9_last_name">Express</string>
-    <string name="account_9_email">express@google.com</string>
+    <string name="account_9_email">express@altostrat.com</string>
 
     <string name="account_10_first_name">Sandra</string>
     <string name="account_10_last_name">Adams</string>
-    <string name="account_10_email">sandraadams@gmail.com</string>
+    <string name="account_10_email">sandraadams@altostrat.com</string>
 
     <string name="account_11_first_name">Trevor</string>
     <string name="account_11_last_name">Hansen</string>
-    <string name="account_11_email">trevorhandsen@gmail.com</string>
+    <string name="account_11_email">trevorhandsen@altostrat.com</string>
 
     <string name="account_12_first_name">Sean</string>
     <string name="account_12_last_name">Holt</string>
-    <string name="account_12_email">sholt@gmail.com</string>
+    <string name="account_12_email">sholt@altostrat.com</string>
 
     <string name="account_13_first_name">Frank</string>
     <string name="account_13_last_name">Hawkins</string>
-    <string name="account_13_email">fhawkank@gmail.com</string>
+    <string name="account_13_email">fhawkank@altostrat.com</string>
 
     <string name="email_0_subject">Package shipped!</string>
     <string name="email_0_body">

build.gradle.kts

@@ -13,13 +13,14 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+// Top-level build file where you can add configuration options common to all sub-projects/modules.
 buildscript {
     extra.apply {
         set("lifecycle_version", "2.6.1")
     }
 }
 
-// Top-level build file where you can add configuration options common to all sub-projects/modules.
 plugins {
     id("com.android.application") version "8.0.2" apply false
     id("com.android.library") version "8.0.2" apply false