Refactor full name, rewrite negative conditional

Author: OwenScott-GDS

app/src/main/java/com/example/reply/data/Account.kt

@@ -32,7 +32,4 @@ data class Account(
     @StringRes val email: Int,
     /** User's avatar image resource id **/
     @DrawableRes val avatar: Int
-) {
-    /** User's full name **/
-    val fullName: String = "$firstName $lastName"
-}
+)

app/src/main/java/com/example/reply/ui/ReplyDetailsScreen.kt

@@ -246,7 +246,8 @@ private fun DetailsScreenHeader(email: Email, modifier: Modifier = Modifier) {
     Row(modifier = modifier) {
         ReplyProfileImage(
             drawableResource = email.sender.avatar,
-            description = email.sender.fullName,
+            description = stringResource(email.sender.firstName) + " "
+                    + stringResource(email.sender.lastName),
             modifier = Modifier.size(
                 dimensionResource(R.dimen.email_header_profile_size)
             )
@@ -288,10 +289,10 @@ private fun ActionButton(
                 .padding(vertical = dimensionResource(R.dimen.detail_action_button_padding_vertical)),
             colors = ButtonDefaults.buttonColors(
                 containerColor =
-                if (!containIrreversibleAction) {
-                    MaterialTheme.colorScheme.primaryContainer
-                } else {
+                if (containIrreversibleAction) {
                     MaterialTheme.colorScheme.onErrorContainer
+                } else {
+                    MaterialTheme.colorScheme.primaryContainer
                 }
             )
         ) {

app/src/main/java/com/example/reply/ui/ReplyHomeContent.kt

@@ -172,7 +172,8 @@ private fun ReplyEmailItemHeader(email: Email, modifier: Modifier = Modifier) {
     Row(modifier = modifier) {
         ReplyProfileImage(
             drawableResource = email.sender.avatar,
-            description = email.sender.fullName,
+            description = stringResource(email.sender.firstName) + " "
+                    + stringResource(email.sender.lastName),
             modifier = Modifier.size(dimensionResource(R.dimen.email_header_profile_size))
         )
         Column(