Migrate to e2e for starter branch#91
Open
the-scrambler wants to merge 2 commits intostarterfrom
Open
Conversation
the-scrambler
force-pushed
the
starter-e2e
branch
from
9e92dfb to
da1062c
Compare
johnshea
approved these changes
Oct 23, 2023
| id("com.android.application") version "8.0.2" apply false | ||
| id("com.android.library") version "8.0.2" apply false | ||
| id("org.jetbrains.kotlin.android") version "1.8.21" apply false | ||
|
|
Contributor
There was a problem hiding this comment.
nit: Remove blank line. It was added on this commit.
| import androidx.activity.compose.setContent | ||
| import androidx.activity.enableEdgeToEdge | ||
| import androidx.compose.foundation.layout.fillMaxSize | ||
| import androidx.compose.material3.MaterialTheme |
Contributor
There was a problem hiding this comment.
This import is unused. Is it needed?
jhansitavva
requested changes
Oct 23, 2023
| window.statusBarColor = colorScheme.background.toArgb() | ||
| WindowCompat.getInsetsController(window, view).isAppearanceLightStatusBars = !darkTheme | ||
| } | ||
| } |
There was a problem hiding this comment.
As discussed lets keep this for all the apps, if you have not updated the codelabs
the-scrambler
force-pushed
the
starter-e2e
branch
from
c06e73a to
e26ddf0
Compare
jhansitavva
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hold off on merge until codelab is updated.