Make safe_divide safer.#2123
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_900660861
branch
2 times, most recently
from
88112e2 to
45fd081
Compare
The current danger of safe_divide is it's easy not to think about numerics and what your edge case behaviour where something goes to zero should be. Making eps a required argument of safe_divide also forces us to think about the numerics involved. PiperOrigin-RevId: 913713697
copybara-service
Bot
force-pushed
the
test_900660861
branch
from
45fd081 to
2cd72d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make safe_divide safer.
The current danger of safe_divide is it's easy not to think about numerics and what your edge case behaviour where something goes to zero should be. Making eps a required argument of safe_divide also forces us to think about the numerics involved.