Persist rho_norm_ped_top in PedestalTransitionState.#2088
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Persist rho_norm_ped_top in PedestalTransitionState.#2088copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
test_890589780
branch
2 times, most recently
from
6b80802 to
1787540
Compare
This change makes rho_norm_ped_top part of the PedestalTransitionState, allowing models that dynamically compute the pedestal top location (like EPEDNN) to propagate this value between timesteps. The rho_norm_ped_top from the pedestal model output at t+dt is now stored in the transition state for use in the next timestep's pre_step processing, ensuring accurate L-mode baseline capture. PiperOrigin-RevId: 890589780
copybara-service
Bot
force-pushed
the
test_890589780
branch
from
1787540 to
6f8657b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist rho_norm_ped_top in PedestalTransitionState.
This change makes rho_norm_ped_top part of the PedestalTransitionState, allowing models that dynamically compute the pedestal top location (like EPEDNN) to propagate this value between timesteps. The rho_norm_ped_top from the pedestal model output at t+dt is now stored in the transition state for use in the next timestep's pre_step processing, ensuring accurate L-mode baseline capture.