Skip to content

runtime: handle ENOTSUP/ENOSYS from poll_oneoff in netpoll_wasip1#78522

Open
ssam18 wants to merge 1 commit intogolang:masterfrom
ssam18:fix/netpoll-wasip1-enotsup
Open

runtime: handle ENOTSUP/ENOSYS from poll_oneoff in netpoll_wasip1#78522
ssam18 wants to merge 1 commit intogolang:masterfrom
ssam18:fix/netpoll-wasip1-enotsup

Conversation

@ssam18
Copy link
Copy Markdown

@ssam18 ssam18 commented Apr 3, 2026

Some WASM host runtimes export poll_oneoff but return ENOTSUP or ENOSYS rather than implementing it, because they're event-driven and blocking the WASM thread would deadlock their worker. This caused a fatal crash during GC cycles in any wasip1 plugin that transitively imports fmt or os — which is nearly everything.

The fix treats ENOTSUP (58) and ENOSYS (52) the same way as returning zero events, which is always safe when there are no real FD subscriptions and harmless otherwise since the scheduler will re-poll on the next GC cycle. This mirrors what netpoll_fake.go already does for the js/wasm target.

Fix for the issue #78513

Some WASM host runtimes (e.g. Envoy proxy-WASM) export poll_oneoff but
return ENOTSUP or ENOSYS because they are event-driven and cannot allow
WASM to block. Previously any non-EINTR error from poll_oneoff caused a
fatal crash, which surfaced during GC cycles in plugins that import fmt
or os. Return zero ready events for these two errnos so the scheduler
continues normally, matching the existing behaviour of netpoll_fake.go
used by the js/wasm target.

Fixes golang#78513
@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: 16fe6e4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/762600.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/762600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/762600.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants