time: wrong Sign Cast in Time.UnmarshalBinary (V2 Format) by cuiweixie · Pull Request #78518 · golang/go

cuiweixie · 2026-04-03T12:17:00Z

Fixes #78528

gopherbot · 2026-04-03T12:24:52Z

This PR (HEAD: d2be799) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/762480.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-04-03T12:34:33Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-03T13:23:44Z

This PR (HEAD: 269afa2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/762480.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-04-03T13:43:00Z

Message from xie cui:

Patch Set 2: Commit-Queue+1 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-03T13:43:01Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-04-03T13:26:44Z","revision":"4aaecb32e653e5cd39f6883c6daf6a20a010e624"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-03T13:43:01Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-03T14:23:13Z

Message from xie cui:

Patch Set 2: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_37653>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-03T14:23:14Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-03T14:23:14Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T08:18:25Z

Message from Ian Lance Taylor:

Patch Set 2: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T08:27:13Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-04-04T08:08:39Z","revision":"4aaecb32e653e5cd39f6883c6daf6a20a010e624"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T08:51:14Z

Message from Ian Lance Taylor:

Patch Set 2: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5206>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T08:51:15Z

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-misccompile has failed with summary (view all results):

go on master (change 762480)

Error: shard 2: failed to run compile goos:"netbsd" goarch:"386" port: exit status 1

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T08:51:15Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T09:00:14Z

Message from xie cui:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T09:00:22Z

This PR (HEAD: fff2909) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/762480.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-04-04T09:09:27Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-04-04T08:49:33Z","revision":"4aaecb32e653e5cd39f6883c6daf6a20a010e624"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T09:18:28Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T09:18:28Z

Message from xie cui:

Patch Set 3: Commit-Queue+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T09:18:29Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-04-04T09:04:36Z","revision":"82bf5a89d1762ec13a9f2f41b93de77370f4322e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T09:18:29Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T09:27:16Z

Message from xie cui:

Patch Set 3: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_37653>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T09:27:17Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-386 has failed with summary (view all results):

go on master (change 762480)

To reproduce, try gomote repro 8685463577362520945.

Additional links for debugging:

go tool dist test -json output [shard 2]

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T09:27:17Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T10:00:45Z

Message from xie cui:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T10:00:45Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-04-04T09:44:16Z","revision":"82bf5a89d1762ec13a9f2f41b93de77370f4322e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T10:09:31Z

Message from xie cui:

Patch Set 3: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_37653>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T10:09:32Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T10:09:32Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T10:27:07Z

Message from Jorropo:

Patch Set 3: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

Fixes golang#78528

gopherbot · 2026-04-04T10:57:20Z

Message from Jorropo:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T10:57:29Z

This PR (HEAD: 3d7f5ef) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/762480.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-04-04T11:15:20Z

Message from Gopher Robot:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T11:24:05Z

Message from Gopher Robot:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T11:24:06Z

Message from xie cui:

Patch Set 4: Commit-Queue+1 Run-TryBot+1

Copied votes on follow-up patch sets have been updated:

Commit-Queue+1 has been copied to patch set 5 (copy condition: "changekind:NO_CODE_CHANGE").

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T11:24:06Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-04-04T11:10:10Z","revision":"cb0e8272029d7567838897739aece98185c2564e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T11:58:13Z

Message from xie cui:

Patch Set 5: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_37653>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T11:58:14Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T11:58:15Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T12:17:03Z

Message from xie cui:

Patch Set 5: Commit-Queue+1 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T12:17:03Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-04-04T12:07:03Z","revision":"cb0e8272029d7567838897739aece98185c2564e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T12:35:19Z

Message from xie cui:

Patch Set 5: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_37653>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T12:35:19Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-04T20:43:41Z

Message from Ian Lance Taylor:

Patch Set 5: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-06T11:33:43Z

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-06T13:39:30Z

Message from Jorropo:

Patch Set 5: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-06T15:22:21Z

Message from xie cui:

Patch Set 5: -Run-TryBot

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

Fixes #78528 Change-Id: I8979a310dbf94b9710d3e8428480cb49a7308294 GitHub-Last-Rev: 3d7f5ef GitHub-Pull-Request: #78518 Reviewed-on: https://go-review.googlesource.com/c/go/+/762480 Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jorropo <jorropo.pgm@gmail.com> Reviewed-by: Junyang Shao <shaojunyang@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>

gopherbot · 2026-04-06T16:18:21Z

Message from David Chase:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-06T16:18:23Z

Message from Junyang Shao:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/762480.
After addressing review feedback, remember to publish your drafts!

cuiweixie force-pushed the time branch from d2be799 to 269afa2 Compare April 3, 2026 13:22

cuiweixie changed the title ~~time: Wrong Sign Cast in Time.UnmarshalBinary (V2 Format)~~ time: wrong Sign Cast in Time.UnmarshalBinary (V2 Format) Apr 3, 2026

cuiweixie force-pushed the time branch from 269afa2 to fff2909 Compare April 4, 2026 08:55

time: wrong Sign Cast in Time.UnmarshalBinary (V2 Format)

3d7f5ef

Fixes golang#78528

cuiweixie force-pushed the time branch from fff2909 to 3d7f5ef Compare April 4, 2026 10:56

Conversation

cuiweixie commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Apr 3, 2026

Uh oh!

gopherbot commented Apr 3, 2026

Uh oh!

gopherbot commented Apr 3, 2026

Uh oh!

gopherbot commented Apr 3, 2026

Uh oh!

gopherbot commented Apr 3, 2026

Uh oh!

gopherbot commented Apr 3, 2026

Uh oh!

gopherbot commented Apr 3, 2026

Uh oh!

gopherbot commented Apr 3, 2026

Uh oh!

gopherbot commented Apr 3, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

gopherbot commented Apr 4, 2026

Uh oh!

cuiweixie commented Apr 3, 2026 •

edited

Loading