Skip to content

Add files via upload#78509

Open
kn1g78 wants to merge 2 commits intogolang:masterfrom
kn1g78:master
Open

Add files via upload#78509
kn1g78 wants to merge 2 commits intogolang:masterfrom
kn1g78:master

Conversation

@kn1g78
Copy link
Copy Markdown

@kn1g78 kn1g78 commented Apr 2, 2026

archive/zip.Reader 在第一次通过 Open / ReadDirfs.FS 方式访问归档时,会先构建一份文件索引。

原来的实现会把 ZIP 中每个条目的隐式父目录都提前补齐,再把这些目录和真实文件一起排序。在目录层级很深、条目很多的归档上,初始化时损耗的资源会变得很高。很多时间都花在构造和整理这些中间目录上,而不是花在真正的查找上。

这次调整优化了如下几条:

  • 初始化时只保留归档中真实存在的条目,并建立按完整路径查找的索引
  • 不再在构建阶段预先展开所有隐式父目录
  • Open 命中一个未显式存在的目录时,再根据前缀判断它是否是一个隐式目录
  • ReadDir 枚举目录时,再按前缀整理当前层级的直接子项

这样做之后,Reader 不需要在第一次访问时把整棵中间目录树先拼出来,尤其能避免深层路径场景下的大量重复工作。

@google-cla
Copy link
Copy Markdown

google-cla bot commented Apr 2, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: 3862300) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/762301.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/762301.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/762301.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/762301.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants