Skip to content

fix: raise on watermark slot failure instead of silent fallback #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
godon-robot merged 1 commit into from
Jun 7, 2026
Merged

fix: raise on watermark slot failure instead of silent fallback #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions controller/breeder_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,6 @@ def _assign_watermark_slot(self, breeder_config):
breeder_list = self.metadata_repo.fetch_breeders_list()
if breeder_list:
for row in breeder_list:
# breeder_list returns (id, name, creation_tsz) — fetch config separately
existing_breeder_id = row[0]
meta_row = self.metadata_repo.fetch_meta_data(existing_breeder_id)
if meta_row and len(meta_row) > 0:
Expand All @@ -251,16 +250,21 @@ def _assign_watermark_slot(self, breeder_config):
slot = existing_config.get('breeder', {}).get('watermark_slot')
if slot is not None:
used_slots.add(slot)
logger.info(f"Existing watermark slots in use: {sorted(used_slots)}")
except Exception as e:
logger.warning(f"Could not read existing breeder slots: {e}. Falling back.")
logger.error(f"Failed to read existing breeder slots from metadata DB: {e}")
raise RuntimeError(f"Cannot assign watermark slot — metadata DB unavailable: {e}") from e

if len(used_slots) < max_slots:
# Assign lowest available slot
assigned_slot = min(s for s in range(max_slots) if s not in used_slots)
breeder_config['breeder']['watermark_slot'] = assigned_slot
logger.info(f"Assigned watermark slot {assigned_slot} (used: {sorted(used_slots)})")
else:
logger.warning(f"All {max_slots} watermark slots in use. Breeder may share frequencies.")
raise RuntimeError(
f"All {max_slots} watermark slots in use ({sorted(used_slots)}). "
f"Cannot create breeder without a collision-free slot."
)

def _resolve_target_refs(self, breeder_config):
"""Resolve targetRefs to inline targets from the targets catalog
Expand Down
Loading