Accept any Que::Adapters::Base subclass in Que.connection=#119
Open
BBrannick wants to merge 1 commit into
Open
Accept any Que::Adapters::Base subclass in Que.connection=#119BBrannick wants to merge 1 commit into
BBrannick wants to merge 1 commit into
Conversation
orlylevk
reviewed
Jun 11, 2026
| self.adapter = | ||
| if connection.to_s == "ActiveRecord" | ||
| Adapters::ActiveRecord.new | ||
| elsif connection.is_a?(Adapters::Base) |
There was a problem hiding this comment.
The other adapters are also inherent from the Base (for example, Adapters::Pond), and it will stop working
probably need to move this below the case for them
Replace the hardcoded class-name whitelist with an is_a?(Adapters::Base) guard, so external adapter subclasses (e.g. defined in consuming apps) can be passed directly without raising "Que connection not recognized". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
BBrannick
force-pushed
the
custom-adapter-index-hints
branch
from
0ad566e to
dc28a65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hardcoded class-name whitelist with an is_a?(Adapters::Base) guard, so external adapter subclasses (e.g. defined in consuming apps) can be passed directly without raising "Que connection not recognized".