Report structurally invalid workflows to users (#37115)#37116
Open
bircni wants to merge 3 commits intogo-gitea:mainfrom
Open
Report structurally invalid workflows to users (#37115)#37116bircni wants to merge 3 commits intogo-gitea:mainfrom
bircni wants to merge 3 commits intogo-gitea:mainfrom
Conversation
`model.ReadWorkflow` succeeds for YAML that is syntactically valid but fails deeper parsing in `jobparser.Parse` (e.g. blank lines inside `run: |` blocks cause a SetJob round-trip error). Add `ValidateWorkflowContent` which runs the full `jobparser.Parse` to catch these cases, and use it in the file view, the actions workflow list, and the workflow detection loop so users see the error instead of silently getting a 500 or a dropped workflow. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Apr 6, 2026
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Apr 7, 2026
| events, err := GetEventsFromContent(content) | ||
| if err == nil { | ||
| err = ValidateWorkflowContent(content) | ||
| } |
Contributor
There was a problem hiding this comment.
Why? GetEventsFromContent already does something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
model.ReadWorkflowsucceeds for YAML that is syntactically valid but fails deeper parsing injobparser.Parse(e.g. blank lines insiderun: |blocks cause a SetJob round-trip error). AddValidateWorkflowContentwhich runs the fulljobparser.Parseto catch these cases, and use it in the file view, the actions workflow list, and the workflow detection loop so users see the error instead of silently getting a 500 or a dropped workflow.Fixes #37115