Fix mirror RemoteAddress not updated when changing mirror address#37083
Open
majorissuerep wants to merge 1 commit intogo-gitea:mainfrom
Open
Fix mirror RemoteAddress not updated when changing mirror address#37083majorissuerep wants to merge 1 commit intogo-gitea:mainfrom
majorissuerep wants to merge 1 commit intogo-gitea:mainfrom
Conversation
…-gitea#28203) UpdateAddress updated repo.OriginalURL but never wrote to mirror.RemoteAddress. The settings UI reads PullMirror.RemoteAddress directly from the DB, so the URL appeared blank whenever it was changed via the settings form. Fix: persist the sanitized URL to mirror.RemoteAddress via UpdateMirror before updating the repository's original_url column. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
GiteaBot
added
the
lgtm/need 2
bircni
suggested changes
Apr 2, 2026
Member
bircni
left a comment
bircni
left a comment
There was a problem hiding this comment.
https://github.com/go-gitea/gitea/blob/main/CONTRIBUTING.md
Please read what claude wrote in the PR for you - there are tasks which are not checked...
GiteaBot
added
lgtm/blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #28203
UpdateAddressinservices/mirror/mirror_pull.goupdatedrepo.OriginalURLbut never wrote the sanitized URL tomirror.RemoteAddress. The settings UI readsPullMirror.RemoteAddressdirectly from the DB, so the mirror URL appeared blank after any address change.m.RemoteAddressto the sanitized URLUpdateMirrorbefore updating the repository'soriginal_urlcolumnTest plan
🤖 Generated with Claude Code