Fix various problems

[wxiaoguang]

Quick fix for 1.26. Complex change is not in this PR's scope. Related to existing PRs which are still WIP or have various problems:

• Fix issue where commenting with a status change could partially fail. #35317
• Fix mixed HTML+JSON error response when issue comment creation fails #36667
• Fix duplicate script declaration error in pull request merge box #36759
• Fix Mermaid code blocks broken on dashboard feed (#36582) #36604

---

• Slightly refactor NewComment to fix incorrect responses, remove incorrect defer (still far from ideal)
• Avoid const causes js error in global scope
• Don't process markup contents on user's home activity feed, to avoid js error due to broken math/mermaid code

---

• Fix Mermaid code block truncated on homepage causes parse error #36582

Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/37077/files?diff=unified&w=1

[Copilot]

Pull request overview

This PR applies a set of targeted fixes for the 1.26 line, focusing on preventing frontend JS errors from truncated markup rendering, avoiding script-scope conflicts in the PR merge box, and refactoring the issue comment creation flow to avoid incorrect/mixed responses.

Changes:

• Skip initializing markup features for truncated markup blocks (e.g. dashboard activity feed) while clearing backend “loading” state.
• Wrap the pull merge box inline module script to avoid duplicate top-level declarations.
• Refactor NewComment to remove the problematic deferred response write and tighten empty-comment validation.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
web_src/js/markup/content.ts	Skips markup feature initialization for .truncated-markup and clears .is-loading.
templates/user/dashboard/feeds.tmpl	Marks dashboard feed comment markup as truncated via truncated-markup class.
templates/repo/issue/view_content/pull_merge_box.tmpl	Wraps inline module script in an IIFE to avoid duplicate declarations.
routers/web/repo/issue_comment.go	Refactors comment creation + close/reopen handling and redirect response flow.
options/locale/locale_en-US.json	Adds a new i18n key for empty comment validation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[silverwind]

Don't process markup contents on user's home activity feed, to avoid js error due to broken mermaid code

Seems ok, we can close the 2 (?) WIP PRs for that with that fix. I discontinued mine because the ask had gotten too complex. Or maybe just keep the simple approach of ommitting code blocks (my initial approach).

[wxiaoguang]

Don't process markup contents on user's home activity feed, to avoid js error due to broken mermaid code

Seems ok, we can close the 2 (?) WIP PRs for that with that fix. I discontinued mine because the ask had gotten too complex. Or maybe just keep the simple approach of ommitting code blocks (my initial approach).

My thoughts about the related PRs:

• Fix issue where commenting with a status change could partially fail. Fix issue where commenting with a status change could partially fail. #35317
  • It is not right, I closed it
• Fix mixed HTML+JSON error response when issue comment creation fails Fix mixed HTML+JSON error response when issue comment creation fails #36667
  • I think the major problem should have been fixed by this refactoring.
  • The "response content type" problem is a big topic, we need to redesign the web framework
  • You can see there are so many "ctx.ServerError" in the whole codebase
  • So I think it can be closed if you don't want to keep it
• Fix duplicate script declaration error in pull request merge box Fix duplicate script declaration error in pull request merge box #36759
  • I think the plan is valuable and right
  • The problem is that I prefer we design the "template data struct" instead of AI, or at least we need to fully understand the change
  • So maybe it can be kept and see whether the logic can be clear
• Fix Mermaid code blocks broken on dashboard feed Fix Mermaid code blocks broken on dashboard feed (#36582) #36604
  • It's up to you, whether there would be a solution for the task of "limit the height in the user home activity feed" and/or whether we will do it right now.

[silverwind]

• Fix mixed HTML+JSON error response when issue comment creation fails #36667 closed, revisit later.
• Fix duplicate script declaration error in pull request merge box #36759 i will pick it up again, it's a valuable fix.
• Fix Mermaid code blocks broken on dashboard feed (#36582) #36604 could be acceptable as-is imho.

[silverwind]

So what is the fix for the frontpage? Still "Don't process markup contents on user's home activity feed"? I think it's bad to show unprocessed markup. I imagine we need a AbbevivateMarkup(markup: string, numChars: int) function which could useful in more than just this place (ContextPopup).

[wxiaoguang]

imagine we need a AbbevivateMarkup(markup: string, numChars: int) function which could useful in more than just this place (ContextPopup).

I think it needs to skip the failed rendering, don't show eye-catching errors:

[silverwind]

I think it needs to skip the failed rendering, don't show eye-catching errors

Yes, no cut-off code blocks, math blocks, inline math, inline code. that makes no sense when being cut off in the middle. Only cut off in the middle inside plain text.