Conversation
|
It seems that most changes are not really needed. |
|
Some screenshots would be helpful. |
According to my review, I think most "devpage" changes should be reverted or refactored. |
|
Yes, no duplicating of implementation details because that would incur extra effort to keep those implementations in sync. It should work on component level (similar to how Storybook can be used for component-level previews/demos/tests). I guess our devtest pages could eventually be replaced with Storybook if desired, it's the same principle. |
There are plenty of "golang template components" or "heavy JS logic component" tested in devtest pages.
Will Storybook work for them? |
Storybook is primarily for testing UI components (Vue, React) in isolation without a backend, so not a a good fit for backend-based components, but a good fit for Vue components (with relevant mocking). |
None of these is "UI components (Vue, React)" |
71f3e5a to
74c1dff
Compare
|
Updated: |
Just curious, but we view the avatars everyday on the UI, they are almost on every page, why it needs a separate devtest page? |
agree... removing too |
|
@silverwind do you agree to use inline scripts and inline styles? |
|
By the way, I think we should drop the imports of the "standalone" JS scripts, merge them into "index.ts" and import them when needed, because the vite can chunk them correctly. The "standalone" modules will cause double-import problem (see my comment in the Webpack to Vite PR) |
|
|
So what do I need to do? what of that is part of this PR? |
When I was developing I sometimes added a devtest page locally for testing purposes, so here is my PR.
Add new pages to devtest: