-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
actions: expose previous job attempts and allow downloading attempt logs #37052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bircni
wants to merge
12
commits into
go-gitea:main
Choose a base branch
from
bircni:feature/access-previous-logs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
00f8374
commit
bircni e5bebaa
fixes
bircni 7935d91
ui
bircni f91b4f2
ui enhancement
bircni f7ec220
simplify
bircni 0803a34
fix swagger
bircni 4fb4b2a
fixes
bircni ff72aa3
fixes to make copilot happy
bircni c5fe724
move ui
bircni 29e6046
remove stale div
bircni 13b92aa
remove stale css
bircni c417779
Merge branch 'main' into feature/access-previous-logs
bircni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ import ( | |
| // ActionTask represents a distribution of job | ||
| type ActionTask struct { | ||
| ID int64 | ||
| JobID int64 | ||
| JobID int64 `xorm:"index"` | ||
| Job *ActionRunJob `xorm:"-"` | ||
| Steps []*ActionTaskStep `xorm:"-"` | ||
| Attempt int64 | ||
|
|
@@ -164,6 +164,30 @@ func GetTaskByID(ctx context.Context, id int64) (*ActionTask, error) { | |
| return &task, nil | ||
| } | ||
|
|
||
| // GetTasksByJobID returns lightweight task metadata for all attempts of a job, | ||
| // ordered by attempt ascending. Only fields needed for the attempts list are selected | ||
| // to avoid loading LogIndexes (LONGBLOB) on every request. | ||
| func GetTasksByJobID(ctx context.Context, jobID int64) ([]*ActionTask, error) { | ||
| var tasks []*ActionTask | ||
| return tasks, db.GetEngine(ctx). | ||
| Cols("id", "job_id", "attempt", "status", "started", "stopped", "log_expired"). | ||
| Where("job_id=?", jobID). | ||
| OrderBy("attempt ASC"). | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since attempt is not indexed, we might could sort it in memory? |
||
| Find(&tasks) | ||
bircni marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| // GetTaskByJobAndAttempt returns the task for a specific attempt of a job. | ||
| func GetTaskByJobAndAttempt(ctx context.Context, jobID, attempt int64) (*ActionTask, error) { | ||
| var task ActionTask | ||
| has, err := db.GetEngine(ctx).Where("job_id=? AND attempt=?", jobID, attempt).Get(&task) | ||
| if err != nil { | ||
| return nil, err | ||
| } else if !has { | ||
| return nil, util.NewNotExistErrorf("task with job_id %d attempt %d", jobID, attempt) | ||
| } | ||
| return &task, nil | ||
| } | ||
|
|
||
| func GetRunningTaskByToken(ctx context.Context, token string) (*ActionTask, error) { | ||
| errNotExist := fmt.Errorf("task with token %q: %w", token, util.ErrNotExist) | ||
| if token == "" { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use
runner_id=? and job_id=?, then this index is not needed.