Support legacy run/job index-based URLs and refactor migration 326

models/actions/run.go

@@ -322,16 +322,16 @@ func GetRunByRepoAndID(ctx context.Context, repoID, runID int64) (*ActionRun, er
 	return &run, nil
 }
 
-func GetRunByIndex(ctx context.Context, repoID, index int64) (*ActionRun, error) {
+func GetRunByRepoAndIndex(ctx context.Context, repoID, runIndex int64) (*ActionRun, error) {
 	run := &ActionRun{
 		RepoID: repoID,
-		Index:  index,
+		Index:  runIndex,
 	}
 	has, err := db.GetEngine(ctx).Get(run)
 	if err != nil {
 		return nil, err
 	} else if !has {
-		return nil, fmt.Errorf("run with index %d %d: %w", repoID, index, util.ErrNotExist)
+		return nil, fmt.Errorf("run with repo_id %d and index %d: %w", repoID, runIndex, util.ErrNotExist)
 	}
 
 	return run, nil

models/actions/run_job.go

@@ -18,6 +18,11 @@ import (
 	"xorm.io/builder"
 )
 
+// MaxJobNumPerRun is the maximum number of jobs in a single run.
+// https://docs.github.com/en/actions/reference/limits#existing-system-limits
+// TODO: check this limit when creating jobs
+const MaxJobNumPerRun = 256
+
 // ActionRunJob represents a job of a run
 type ActionRunJob struct {
 	ID                int64

models/migrations/fixtures/Test_FixCommitStatusTargetURLToUseRunAndJobID/action_run.yml

@@ -1,9 +1,29 @@
 # type ActionRun struct {
-#   ID     int64 `xorm:"pk autoincr"`
-#   RepoID int64 `xorm:"index"`
-#   Index  int64
+#   ID           int64 `xorm:"pk autoincr"`
+#   RepoID       int64 `xorm:"index"`
+#   Index        int64
+#   CommitSHA    string `xorm:"commit_sha"`
+#   Event        string
+#   TriggerEvent string
+#   EventPayload string `xorm:"LONGTEXT"`
 # }
 -
-  id: 106
-  repo_id: 1
+  id: 990
+  repo_id: 100
   index: 7
+  commit_sha: merge-sha
+  event: pull_request
+  event_payload: '{"pull_request":{"head":{"sha":"sha-shared"}}}'
+-
+  id: 991
+  repo_id: 100
+  index: 8
+  commit_sha: sha-shared
+  event: push
+  event_payload: '{"head_commit":{"id":"sha-shared"}}'
+-
+  id: 1991
+  repo_id: 100
+  index: 9
+  commit_sha: sha-other
+  event: release

models/migrations/fixtures/Test_FixCommitStatusTargetURLToUseRunAndJobID/action_run_job.yml

@@ -3,8 +3,14 @@
 #   RunID int64 `xorm:"index"`
 # }
 -
-  id: 530
-  run_id: 106
+  id: 997
+  run_id: 990
 -
-  id: 531
-  run_id: 106
+  id: 998
+  run_id: 990
+-
+  id: 1997
+  run_id: 991
+-
+  id: 1998
+  run_id: 1991

models/migrations/fixtures/Test_FixCommitStatusTargetURLToUseRunAndJobID/commit_status.yml

@@ -1,29 +1,51 @@
 # type CommitStatus struct {
 #   ID        int64 `xorm:"pk autoincr"`
 #   RepoID    int64 `xorm:"index"`
+#   SHA       string
 #   TargetURL string
 # }
 -
-  id: 10
-  repo_id: 1
+  id: 10010
+  repo_id: 100
+  sha: sha-shared
   target_url: /testuser/repo1/actions/runs/7/jobs/0
 -
-  id: 11
-  repo_id: 1
+  id: 10011
+  repo_id: 100
+  sha: sha-shared
   target_url: /testuser/repo1/actions/runs/7/jobs/1
 -
-  id: 12
-  repo_id: 1
+  id: 10012
+  repo_id: 100
+  sha: sha-shared
+  target_url: /testuser/repo1/actions/runs/8/jobs/0
+-
+  id: 10013
+  repo_id: 100
+  sha: sha-other
+  target_url: /testuser/repo1/actions/runs/9/jobs/0
+-
+  id: 10014
+  repo_id: 100
+  sha: sha-shared
   target_url: /otheruser/badrepo/actions/runs/7/jobs/0
 -
-  id: 13
-  repo_id: 1
+  id: 10015
+  repo_id: 100
+  sha: sha-shared
   target_url: /testuser/repo1/actions/runs/10/jobs/0
 -
-  id: 14
-  repo_id: 1
+  id: 10016
+  repo_id: 100
+  sha: sha-shared
   target_url: /testuser/repo1/actions/runs/7/jobs/3
 -
-  id: 15
-  repo_id: 1
+  id: 10017
+  repo_id: 100
+  sha: sha-shared
   target_url: https://ci.example.com/build/123
+-
+  id: 10018
+  repo_id: 100
+  sha: sha-shared
+  target_url: /testuser/repo1/actions/runs/990/jobs/997

models/migrations/fixtures/Test_FixCommitStatusTargetURLToUseRunAndJobID/commit_status_summary.yml

@@ -6,14 +6,14 @@
 #   TargetURL string
 # }
 -
-  id: 20
-  repo_id: 1
-  sha: "012345"
-  state: success
+  id: 10020
+  repo_id: 100
+  sha: sha-shared
+  state: pending
   target_url: /testuser/repo1/actions/runs/7/jobs/0
 -
-  id: 21
-  repo_id: 1
-  sha: "678901"
-  state: success
-  target_url: https://ci.example.com/build/123
+  id: 10021
+  repo_id: 100
+  sha: sha-other
+  state: pending
+  target_url: /testuser/repo1/actions/runs/9/jobs/0

models/migrations/fixtures/Test_FixCommitStatusTargetURLToUseRunAndJobID/repository.yml

@@ -4,6 +4,6 @@
 #   Name      string
 # }
 -
-  id: 1
+  id: 100
   owner_name: testuser
   name: repo1

models/migrations/migrations.go

@@ -400,7 +400,7 @@ func prepareMigrationTasks() []*migration {
 		newMigration(323, "Add support for actions concurrency", v1_26.AddActionsConcurrency),
 		newMigration(324, "Fix closed milestone completeness for milestones with no issues", v1_26.FixClosedMilestoneCompleteness),
 		newMigration(325, "Fix missed repo_id when migrate attachments", v1_26.FixMissedRepoIDWhenMigrateAttachments),
-		newMigration(326, "Migrate commit status target URL to use run ID and job ID", v1_26.FixCommitStatusTargetURLToUseRunAndJobID),
+		newMigration(326, "Partially migrate commit status target URL to use run ID and job ID", v1_26.FixCommitStatusTargetURLToUseRunAndJobID),
 		newMigration(327, "Add disabled state to action runners", v1_26.AddDisabledToActionRunner),
 		newMigration(328, "Add TokenPermissions column to ActionRunJob", v1_26.AddTokenPermissionsToActionRunJob),
 		newMigration(329, "Add unique constraint for user badge", v1_26.AddUniqueIndexForUserBadge),