Add summary to action runs view#36883
Conversation
|
@xDarkmanx curious to hear your take on this 🙂 |
|
This is also a preparation for #36098 |
There was a problem hiding this comment.
Pull request overview
Adds a “run summary” mode to the repository Actions run view when /actions/runs/{run} is opened without a job segment, so the UI no longer defaults to job 0 and instead shows run-level information plus the workflow graph.
Changes:
- Backend: Treat missing
{job}as summary mode (jobIndex = -1), skip log/task loading, and extend the run payload withduration,triggeredAt, andtriggerEvent. - Frontend: Add summary-mode UI (summary panel + always-on workflow graph) and adjust sidebar structure to include a “Summary” entry and “All jobs” label.
- Localization/templates: Add required locale strings and pass them into the Vue app via
data-locale-*attributes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| web_src/js/features/repo-actions.ts | Passes new summary-related locale strings into the RepoActionView app. |
| web_src/js/components/RepoActionView.vue | Implements summary-mode behavior (no log fetching) and renders run summary + graph UI. |
| templates/repo/actions/view_component.tmpl | Exposes new locale strings via data-locale-* attributes for the frontend. |
| routers/web/repo/actions/view.go | Adds summary-mode routing behavior and extends the JSON response with run summary fields. |
| options/locale/locale_en-US.json | Adds English strings for the new summary UI labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Nicolas <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Nicolas <[email protected]>
|
@silverwind lets solve these issues somewhere else? |
|
@silverwind do you like this top bar better? |
Yes seems good, fix contrast issues, vertical centering and increase spacing between header and value a bit. |
Oh, so the graph is not from this PR but pre-existing? If that's the case, then yes, don't touch it. |
|
@silverwind fixed |
|
@wxiaoguang you were right - I refactored it 😄 |
I think you can |
Oh yes, it is in the left list, I missed it ...... the UI looks somewhat counterintuitive (no rerun button for a single job at the same place as the "summary" page), but I think it isn't really a problem. |
aac1f2a to
7f82a72
Compare
* giteaofficial/main: Add user badges (go-gitea#36752) Apply as maintainer (go-gitea#36947) Refactor storage content-type handling of ServeDirectURL (go-gitea#36804) Add summary to action runs view (go-gitea#36883) feat: Add configurable permissions for Actions automatic tokens (go-gitea#36173) Feature: Add button to re-run failed jobs in Actions (go-gitea#36924) Support dark/light theme images in markdown (go-gitea#36922) fix go-gitea#36463: preserve sort order of exclusive labels from template repo (go-gitea#36931) fix(upgrade.sh): use HTTPS for GPG key import and restore SELinux context after upgrade (go-gitea#36930) [skip ci] Updated translations via Crowdin Make container registry support Apple Container (basic auth) (go-gitea#36920) Fix various trivial problems (go-gitea#36921)
* origin/main: Update to eslint 10 (go-gitea#36925) Add user badges (go-gitea#36752) Apply as maintainer (go-gitea#36947) Refactor storage content-type handling of ServeDirectURL (go-gitea#36804) Add summary to action runs view (go-gitea#36883) feat: Add configurable permissions for Actions automatic tokens (go-gitea#36173) Feature: Add button to re-run failed jobs in Actions (go-gitea#36924) Support dark/light theme images in markdown (go-gitea#36922) fix go-gitea#36463: preserve sort order of exclusive labels from template repo (go-gitea#36931) fix(upgrade.sh): use HTTPS for GPG key import and restore SELinux context after upgrade (go-gitea#36930) [skip ci] Updated translations via Crowdin Make container registry support Apple Container (basic auth) (go-gitea#36920) Fix various trivial problems (go-gitea#36921) [skip ci] Updated translations via Crowdin # Conflicts: # package.json # pnpm-lock.yaml
It it CERTAIN you blindly approved "Restyle Workflow Graph #36912" without testing it, AGAIN. |
|
I did mention contrast issues in #36883 (comment) but those were apparently ignored. And I never approved this. |
It's said it has been fixed #36883 (comment). You also said "Oh, so the graph is not from this PR but pre-existing? If that's the case, then yes, don't touch it." #36883 (comment).
I approved, 2 approvals. What's the problem? |
- Fix `.left-list-header` unreadable on dark theme by using `--color-text-light-2` instead of `--color-grey` - Fix `.graph-metrics` bullet inheriting blue color - Improve summary block layout with horizontal flexbox - Add dot separator between status and duration Co-Authored-By: Claude (claude-opus-4-6) <[email protected]>
- Fix `.left-list-header` unreadable on dark theme by using `--color-text-light-2` instead of `--color-grey` - Fix `.graph-metrics` bullet inheriting blue color - Improve summary block layout with horizontal flexbox - Add dot separator between status and duration Co-Authored-By: Claude (claude-opus-4-6) <[email protected]>
|
The problematic
I thought you wanted to blame me for this problem. |
I was just talking about "it's not right to approve a large PR without really testing it" You approved ""Restyle Workflow Graph #36912" twice, it does contain the fix.
|
- Fix `.left-list-header` unreadable on dark theme by using `--color-text-light-2` instead of `--color-grey` - Fix `.graph-metrics` bullet inheriting blue color - Improve summary block layout with horizontal flexbox - Add dot separator between status and duration Co-Authored-By: Claude (claude-opus-4-6) <[email protected]>









When opening a run without a job in the path (/actions/runs/{run} instead of .../runs/{run}/jobs/{job}), show a run summary instead of defaulting to job 0.
If the {job} segment is missing, treat it as summary mode (jobIndex = -1). In that case, skip loading logs and only return run-level data (run + jobs). Run payload is extended with duration, triggeredAt, and triggerEvent for the summary UI.
In summary mode, the right panel shows a short run summary (trigger, status, total duration, artifact count) and the workflow graph. The sidebar gets a “Summary” entry at the top, a divider, an “All jobs” label, then the job list. The “Workflow graph” toggle is hidden on the summary page (graph is always shown). Log loading, hash handling, and storage options are no-ops in summary mode.