Fix - new test: should not render modal when isOpen is false#454
Open
Lucbm99 wants to merge 1 commit into
Open
Fix - new test: should not render modal when isOpen is false#454Lucbm99 wants to merge 1 commit into
Lucbm99 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new test to ensure the modal is closed when the isOpen prop is set to false. This would help check the conditional rendering behavior of the modal.
What we are testing: Whether the PluginsModal component does not render the modal when the isOpen property is false.
What we expect: That the modal is not rendered, so the test checks if Modal does not exist (exists() returns false).