Skip to content

Flag is added to prevent publishing ip of the node, otherwise, traefi…#703

Open
colcek wants to merge 1 commit intogliderlabs:masterfrom
colcek:feature/use-ip-from-container
Open

Flag is added to prevent publishing ip of the node, otherwise, traefi…#703
colcek wants to merge 1 commit intogliderlabs:masterfrom
colcek:feature/use-ip-from-container

Conversation

@colcek
Copy link
Copy Markdown

@colcek colcek commented Aug 15, 2021

Traefik and other auto discovery systems registers same service twice because it appears twice with its own internal ip and ip of the node. In single node settings, it causes a problem.

@argosback
Copy link
Copy Markdown

Hey @colcek — this PR inspired the -ip-from-container flag implemented in https://github.com/fayrus/registrator. The behavior matches exactly what you described: when the flag is set, the container's internal IP is used for service registration instead of the host IP, which prevents duplicate registrations with Traefik and similar systems. Credit is noted in the changelog. Thanks for the contribution here — it's a real-world fix that deserved to land somewhere.

@argosback argosback mentioned this pull request May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants