Use AgentServiceCheck.Args when registering Consul script/container checks#627
Use AgentServiceCheck.Args when registering Consul script/container checks#627scottatron wants to merge 1 commit into
Conversation
…hecks Consul [recently replaced][1] the Script field from AgentServiceCheck with an Args string slice. This updates the creation of these checks to use the Args field. [1]: hashicorp/consul@b73323a#diff-4f360b6361d9900f98e2f244a3411bc4
|
I have tested this against Consul v.1.0.7 and v.1.1.0 |
|
I've looked at this a little more closely, and it seems as though Seems like a pretty quick deprecation/removal, and I wouldn't have expected a breaking change like that in a point release. In order to all versions of Consul, this change will need to be updated to support both the |
|
Hi @scottatron, looks like we both stumbled on the same issue and the same fix. I have an updated PR that also pins the |
|
Issue is still outstanding, and I've also introduced a similar PR in #669 before finding these. Let's hope there is some action on this soon. |
3 participants
Consul recently replaced the Script field from AgentServiceCheck with an Args string slice.
This updates the creation of these checks to use the Args field.