Conversation
Author
|
Hey! This is my first PR in anything Gleam-related and I'm super excited about it! |
Member
|
Hello! I've changed this to target the v5 branch. Could you remove the formatting changes and rebase to remove the merge conflicts please 🙏 |
Member
|
Tag me once you're done and need a review please @ivamly. Thank you! |
lpil
marked this pull request as draft
September 7, 2026 09:21
ivamly
force-pushed
the
feat/query
branch
3 times, most recently
from
September 14, 2026 19:09
cba1ac5 to
2b2f4d9
Compare
ivamly
marked this pull request as ready for review
September 14, 2026 19:10
Author
|
@lpil done! |
Author
|
@lpil ping |
lpil
reviewed
Sep 22, 2026
| /// Proxies that support this should only do so for known trustworthy | ||
| /// clients. | ||
| Connect | ||
| Query |
Member
There was a problem hiding this comment.
Include documentation for this new method please, matching the others 🙏
ivamly
force-pushed
the
feat/query
branch
2 times, most recently
from
September 22, 2026 18:06
0f327c2 to
41714e8
Compare
Author
|
@lpil, fixed |
Author
|
@lpil ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add QUERY HTTP method support
Closes #81