Conversation
lpil
reviewed
Mar 15, 2026
lpil
left a comment
lpil
left a comment
Member
There was a problem hiding this comment.
Lovely, thank you! I've left some notes inline RE the implementation, as pop_grapheme is avoided as much as possible when parsing strings.
jtdowney
force-pushed
the
link-header
branch
from
September 2, 2026 16:29
2eea444 to
2e95e5e
Compare
jtdowney
force-pushed
the
link-header
branch
from
September 2, 2026 16:31
2e95e5e to
8ddaec9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78