[test-improver] Improve tests for server http_helpers package

[github-actions]

Test Improvements: internal/server/http_helpers_test.go

File Analyzed

• Test File: internal/server/http_helpers_test.go
• Package: internal/server
• Lines of Code: 733 → 867 (+134 lines)

Improvements Made

1. Increased Coverage — Direct Tests for writeErrorResponse

Problem: writeErrorResponse in http_helpers.go is the canonical helper called by every HTTP error path in the server package (auth rejections, shutdown rejections, etc.). Despite this central role, it had no dedicated unit test — it was only exercised indirectly via higher-level tests such as TestWrapWithMiddleware.

New test: TestWriteErrorResponse — 6 subtests covering all common HTTP error status codes:

• ✅ 400 Bad Request — verifies bad_request error code and message
• ✅ 401 Unauthorized — verifies unauthorized error code
• ✅ 403 Forbidden — verifies forbidden error code
• ✅ 404 Not Found — verifies not_found error code
• ✅ 500 Internal Server Error — verifies internal_error error code
• ✅ 503 Service Unavailable — verifies service_unavailable error code

Each subtest asserts:

• HTTP status code matches the input
• Content-Type: application/json header is set
• Response body is valid JSON
• "error" field equals the code argument
• "message" field equals the message argument

2. Increased Coverage — Direct Tests for rejectRequest

Problem: rejectRequest composes logRuntimeError + writeErrorResponse into a single call used at every request-rejection site. It had no direct test — its behavior was only observed through integration-style middleware tests.

New test: TestRejectRequest — 3 subtests covering realistic rejection scenarios:

• ✅ 401 missing Authorization header — auth rejection path
• ✅ 401 invalid API key — key mismatch rejection path
• ✅ 503 Gateway shutting down — shutdown rejection path

Each subtest asserts:

• No panic occurs for any valid input
• HTTP status code matches
• Content-Type: application/json header is set
• Response body is valid JSON with correct "error" and "message" fields

3. Cleaner & More Stable Tests

• ✅ Table-driven tests with descriptive names following existing file conventions
• ✅ Added "encoding/json" import (only addition to the import block)
• ✅ Uses require.NoError for JSON decode (stops test on body parse failure before further assertions)
• ✅ Uses assert.Equal for all field-level checks (clear diff output on failure)
• ✅ Isolated: each subtest creates its own httptest.NewRecorder() and httptest.NewRequest() — no shared state

Why These Changes?

writeErrorResponse is the single source of truth for the JSON shape of all HTTP error responses across the server package. A regression there (e.g., wrong field name, wrong content-type) would silently break clients. Despite being simple, it had no direct test. Similarly, rejectRequest — which drives auth and shutdown rejection — was only covered as a side-effect of middleware tests, making failures harder to pinpoint.

These two tests are small, fast, and deterministic: they exercise only in-process HTTP plumbing with no external dependencies.

---

Generated by Test Improver Workflow
Focuses on better patterns, increased coverage, and more stable tests

Generated by Test Improver · ◷

[Copilot]

Pull request overview

Improves unit test coverage in internal/server by adding direct, table-driven tests for core HTTP error response helpers to ensure consistent JSON error shapes and headers across server error paths.

Changes:

• Added direct tests for writeErrorResponse covering common HTTP status codes and validating JSON shape (error, message), status, and Content-Type.
• Added direct tests for rejectRequest covering realistic rejection scenarios and validating no panics plus response correctness.
• Added encoding/json import to support structured JSON decoding assertions.

Show a summary per file

File	Description
internal/server/http_helpers_test.go	Adds new unit tests for writeErrorResponse and rejectRequest and supporting JSON decoding import.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0