-
-
Notifications
You must be signed in to change notification settings - Fork 66
ci(release): Switch from action-prepare-release to Craft #1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 10 commits
5b7c296
450f8a9
403e8c2
e9a46ba
dc88a07
0ac249d
c37fca0
8676966
221609c
eb6ec6b
fc8eb44
1ec9171
354af49
4ba8a0f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| name: Changelog Preview | ||
| on: | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - synchronize | ||
| - reopened | ||
| - edited | ||
| - labeled | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| changelog-preview: | ||
| uses: getsentry/craft/.github/workflows/changelog-preview.yml@v2 | ||
| secrets: inherit | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,38 +3,36 @@ on: | |
| workflow_dispatch: | ||
| inputs: | ||
| version: | ||
| description: Version to release (optional) | ||
| description: Version to release (or "auto") | ||
| required: false | ||
| force: | ||
| description: Force a release even when there are release-blockers (optional) | ||
| description: Force a release even when there are release-blockers | ||
| required: false | ||
| schedule: | ||
| # We want the release to be at 9-10am Pacific Time | ||
| # We also want it to be 1 hour before the on-prem release | ||
| - cron: '0 17 15 * *' # 5pm UTC on the 15th of every month | ||
| - cron: '0 17 15 * *' | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| release: | ||
| runs-on: ubuntu-latest | ||
| name: "Release a new Symbolicator version" | ||
|
|
||
| name: Release a new version | ||
| steps: | ||
| - name: Get auth token | ||
| id: token | ||
| uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf # v2.2.1 | ||
| with: | ||
| app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }} | ||
| private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }} | ||
|
|
||
| - uses: actions/checkout@v6.0.1 | ||
| with: | ||
| token: ${{ steps.token.outputs.token }} | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Prepare release | ||
| uses: getsentry/action-prepare-release@v1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.token.outputs.token }} | ||
| with: | ||
| version: ${{ github.event.inputs.version }} | ||
| force: ${{ github.event.inputs.force }} | ||
| calver: true | ||
| - name: Get auth token | ||
| id: token | ||
| uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf # v2 | ||
| with: | ||
| app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }} | ||
| private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }} | ||
| - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6 | ||
| with: | ||
| token: ${{ steps.token.outputs.token }} | ||
| fetch-depth: 0 | ||
| - name: Prepare release | ||
| uses: getsentry/craft@1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce # v2 | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.token.outputs.token }} | ||
| with: | ||
| version: ${{ inputs.version }} | ||
| force: ${{ inputs.force }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The scheduled release workflow passes empty strings for Suggested FixConditionally provide a default value for the inputs when the workflow is triggered by a schedule. For example, you can use a ternary expression to default to 'auto' for the version: Prompt for AI AgentDid we get this right? 👍 / 👎 to inform future reviews. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,21 @@ | ||
| name: Update Dependencies | ||
|
|
||
| on: | ||
| # Run every Monday at 3am. | ||
| schedule: | ||
| - cron: '0 3 * * 1' | ||
| # Allow a manual trigger to be able to run the update when there are new dependencies or after a PR merge to resolve CHANGELOG conflicts. | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| native: | ||
| uses: getsentry/github-workflows/.github/workflows/updater.yml@v3 | ||
| with: | ||
| path: crates/symbolicator-crash/sentry-native | ||
| name: Native SDK | ||
| secrets: | ||
| api-token: ${{ secrets.CI_DEPLOY_KEY }} | ||
| name: Update Dependencies | ||
|
|
||
| on: | ||
| # Run every Monday at 3am. | ||
| schedule: | ||
| - cron: '0 3 * * 1' | ||
| # Allow a manual trigger to be able to run the update when there are new dependencies or after a PR merge to resolve CHANGELOG conflicts. | ||
| workflow_dispatch: | ||
|
|
||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| jobs: | ||
| native: | ||
| uses: getsentry/github-workflows/.github/workflows/updater.yml@v3 | ||
| with: | ||
| path: crates/symbolicator-crash/sentry-native | ||
| name: Native SDK | ||
| secrets: | ||
| api-token: ${{ secrets.CI_DEPLOY_KEY }} |
Uh oh!
There was an error while loading. Please reload this page.