Skip to content

fix(ai-conversations): Escape conversation IDs in query strings #112455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgrozdanic merged 1 commit into from
Apr 8, 2026
+6 −4
Merged

fix(ai-conversations): Escape conversation IDs in query strings #112455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/sentry/api/endpoints/organization_ai_conversation_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from sentry.api.paginator import GenericOffsetPaginator
from sentry.api.utils import handle_query_errors
from sentry.models.organization import Organization
from sentry.search.eap.occurrences.query_utils import build_escaped_term_filter
from sentry.search.eap.types import SearchResolverConfig
from sentry.snuba.referrer import Referrer
from sentry.snuba.spans_rpc import Spans
Expand Down Expand Up @@ -125,7 +126,7 @@ def _fetch_conversation_spans(
):
result = Spans.run_table_query(
params=snuba_params,
query_string=f"gen_ai.conversation.id:{conversation_id}",
query_string=build_escaped_term_filter("gen_ai.conversation.id", [conversation_id]),
selected_columns=selected_columns,
orderby=["precise.start_ts"],
offset=offset,
Expand Down
7 changes: 4 additions & 3 deletions src/sentry/api/endpoints/organization_ai_conversations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from sentry.api.serializers.rest_framework import OrganizationAIConversationsSerializer
from sentry.api.utils import handle_query_errors
from sentry.models.organization import Organization
from sentry.search.eap.occurrences.query_utils import build_escaped_term_filter
from sentry.search.eap.resolver import SearchResolver
from sentry.search.eap.types import EAPResponse, SearchResolverConfig
from sentry.search.events.constants import NON_FAILURE_STATUS
Expand Down Expand Up @@ -341,7 +342,7 @@ def _build_aggregations_query(
) -> TableQuery:
return TableQuery(
name="aggregations",
query_string=f"gen_ai.conversation.id:[{','.join(conversation_ids)}]",
query_string=build_escaped_term_filter("gen_ai.conversation.id", conversation_ids),
selected_columns=[
"gen_ai.conversation.id",
"failure_count()",
Expand All @@ -365,7 +366,7 @@ def _build_enrichment_query(
) -> TableQuery:
return TableQuery(
name="enrichment",
query_string=f"gen_ai.conversation.id:[{','.join(conversation_ids)}] has:gen_ai.operation.type",
query_string=f"{build_escaped_term_filter('gen_ai.conversation.id', conversation_ids)} has:gen_ai.operation.type",
selected_columns=[
"gen_ai.conversation.id",
"gen_ai.operation.type",
Expand All @@ -392,7 +393,7 @@ def _build_first_last_io_query(
) -> TableQuery:
return TableQuery(
name="first_last_io",
query_string=f"gen_ai.conversation.id:[{','.join(conversation_ids)}] gen_ai.operation.type:ai_client",
query_string=f"{build_escaped_term_filter('gen_ai.conversation.id', conversation_ids)} gen_ai.operation.type:ai_client",
selected_columns=[
"gen_ai.conversation.id",
"gen_ai.input.messages",
Expand Down
Loading