Skip to content

ref(dynamic-sampling): Drop CustomDynamicSamplingRule tables #112453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shellmayr merged 4 commits into from
Apr 9, 2026
+25 −1
Merged

ref(dynamic-sampling): Drop CustomDynamicSamplingRule tables #112453

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79f00d3
ref(migrations): Drop CustomDynamicSamplingRule tables
shellmayr Apr 8, 2026
1ee6b3d
ref(migrations): Add historical silo assignments for CustomDynamicSam…
shellmayr Apr 8, 2026
512ce4b
ref(migrations): Update lockfile for migration 1065
shellmayr Apr 8, 2026
e51be39
Merge branch 'master' into simon-hellmayr/ref/delete-customdynamicsam…
shellmayr Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ replays: 0007_organizationmember_replay_access

seer: 0005_delete_seerorganizationsettings

sentry: 1064_eventattachment_date_expires_now
sentry: 1065_delete_customdynamicsamplingrule

social_auth: 0003_social_auth_json_field

Expand Down
2 changes: 2 additions & 0 deletions src/sentry/db/router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ class SiloRouter:
"sentry_alertruleactivations": SiloMode.CELL,
"sentry_alertruleactivationcondition": SiloMode.CELL,
"sentry_code_review_event": SiloMode.CELL,
"sentry_customdynamicsamplingrule": SiloMode.CELL,
"sentry_customdynamicsamplingruleproject": SiloMode.CELL,
"sentry_dashboardwidgetsnapshot": SiloMode.CELL,
"sentry_datasecrecywaiver": SiloMode.CELL,
"sentry_incidentseen": SiloMode.CELL,
Expand Down
22 changes: 22 additions & 0 deletions src/sentry/migrations/1065_delete_customdynamicsamplingrule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
from sentry.new_migrations.migrations import CheckedMigration
from sentry.new_migrations.monkey.models import SafeDeleteModel
from sentry.new_migrations.monkey.state import DeletionAction


class Migration(CheckedMigration):
is_post_deployment = False

dependencies = [
("sentry", "1064_eventattachment_date_expires_now"),
]

operations = [
SafeDeleteModel(
name="CustomDynamicSamplingRuleProject",
deletion_action=DeletionAction.DELETE,
),
SafeDeleteModel(
name="CustomDynamicSamplingRule",
deletion_action=DeletionAction.DELETE,
),
]
Loading