fix(rpc): fix seer RPC exception handling to default to 500 and preserve rest APIException

[aliu39]

Problem

When Seer makes RPC calls to Sentry and encounters downstream errors (like 429 rate limits or 500 errors from Snuba), the current code catches all exceptions and re-raises them as ValidationError (400). This misrepresents the actual issue, making it appear as if the client sent bad request parameters when the real cause is a downstream service error.

Example issue: https://sentry.dev.getsentry.net:7999/issues/7380803020/events/d3e6e1d5ddf44d7b94c86e6ce2435ea6/

Solution

This PR fixes the exception handling in the seer RPC endpoint to raise a generic 500 APIException by default, implying an error happened on sentry server. Also re-raises APIException's (base class for rest framework excs) so developers can bubble their own status codes up to response for Seer.

1. Added a handler to re-raise REST framework exceptions directly - Any APIException (which includes Throttled, custom API exceptions, etc.) is now re-raised as-is, preserving its status code
2. Changed generic exception handler to raise APIException (500) instead of ValidationError (400) - Unknown errors now correctly return 500 Internal Server Error instead of 400 Bad Request

Changes

• Modified SeerRpcServiceEndpoint.post() in src/sentry/seer/endpoints/seer_rpc.py:
  • Added except APIException: raise handler before the generic exception handler
  • Changed raise ValidationError from e to raise APIException from e for generic exceptions
• Added test cases in tests/sentry/seer/endpoints/test_seer_rpc.py:
  • test_rest_framework_exceptions_are_reraised - verifies custom API exceptions preserve their status codes
  • test_generic_exceptions_return_500 - verifies generic exceptions return 500 instead of 400

Testing

Pre-commit checks pass ✅

Slack Thread

  

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Test doesn't exercise the new APIException code path
  • Mocked in_test_environment() to return False so the test properly exercises the APIException conversion code path instead of re-raising the original exception.

Or push these changes by commenting:

@cursor push bbfaa3b8be

Preview (bbfaa3b8be)

diff --git a/tests/sentry/seer/endpoints/test_seer_rpc.py b/tests/sentry/seer/endpoints/test_seer_rpc.py
--- a/tests/sentry/seer/endpoints/test_seer_rpc.py
+++ b/tests/sentry/seer/endpoints/test_seer_rpc.py
@@ -112,9 +112,12 @@
         path = self._get_path("get_organization_slug")
         data: dict[str, Any] = {"args": {"org_id": 1}, "meta": {}}
 
-        with patch(
-            "sentry.seer.endpoints.seer_rpc.SeerRpcServiceEndpoint._dispatch_to_local_method"
-        ) as mock_dispatch:
+        with (
+            patch(
+                "sentry.seer.endpoints.seer_rpc.SeerRpcServiceEndpoint._dispatch_to_local_method"
+            ) as mock_dispatch,
+            patch("sentry.seer.endpoints.seer_rpc.in_test_environment", return_value=False),
+        ):
             mock_dispatch.side_effect = RuntimeError("Unexpected internal error")
 
             response = self.client.post(

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 388d7ab. Configure here.}

[aliu39]

Re cursor: not sure how to simulate non-test environment from a test.. code seems straightforward enough to not cover