feat(seer): Add Night Shift nightly autofix cron scaffolding by trevor-e · Pull Request #112429 · getsentry/sentry

trevor-e · 2026-04-07T22:56:31Z

Add the scaffolding for a nightly cron job ("Night Shift") that fans out per-org to trigger Seer Autofix on top issues. This decouples automation from the hot post_process pipeline, enabling better issue selection and serving lower-volume orgs.

The scheduler iterates active orgs using batched feature flag checks (batch_has_for_organizations) to avoid N+1, applies deterministic jitter to spread load, and dispatches per-org worker tasks. The worker task is currently a stub that just logs — the issue selection and autofix triggering logic will be added in a follow-up once we've decided on the approach.

What's included:

schedule_night_shift() — cron scheduler task (daily at 10:00 AM UTC / ~2-3 AM PT)
run_night_shift_for_org() — per-org worker task (stub for now)
Feature flag: organizations:seer-night-shift (flagpole, disabled by default)
Options: seer.night_shift.enable (global killswitch), seer.night_shift.issues_per_org
NIGHT_SHIFT referrer and automation source enums
Cron schedule entry in TASKWORKER_REGION_SCHEDULES

Not included (follow-ups):

Issue selection logic in the worker task
Options-automator config (must deploy this PR first)

Refs https://www.notion.so/sentry/Seer-Night-Shift-3338b10e4b5d807e80a6fbd6d70b3f60

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix prepared fixes for both issues found in the latest run.

✅ Fixed: Function name contains spurious _d7 suffix
- Renamed function from _get_eligible_org_ids_from_batch_d7 to _get_eligible_org_ids_from_batch, removing the spurious suffix.
✅ Fixed: Unused module-level constant NIGHT_SHIFT_AUTO_RUN_SOURCE
- Removed the unused NIGHT_SHIFT_AUTO_RUN_SOURCE constant and its associated SeerAutomationSource import.

Or push these changes by commenting:

@cursor push 6aeb4ee3ef

Preview (6aeb4ee3ef)

diff --git a/src/sentry/tasks/seer/night_shift.py b/src/sentry/tasks/seer/night_shift.py
--- a/src/sentry/tasks/seer/night_shift.py
+++ b/src/sentry/tasks/seer/night_shift.py
@@ -8,7 +8,6 @@
 
 from sentry import features, options
 from sentry.models.organization import Organization, OrganizationStatus
-from sentry.seer.autofix.constants import SeerAutomationSource
 from sentry.tasks.base import instrumented_task
 from sentry.taskworker.namespaces import seer_tasks
 from sentry.utils.iterators import chunked
@@ -24,9 +23,7 @@
     "organizations:gen-ai-features",
 ]
 
-NIGHT_SHIFT_AUTO_RUN_SOURCE = SeerAutomationSource.NIGHT_SHIFT.value
 
-
 @instrumented_task(
     name="sentry.tasks.seer.night_shift.schedule_night_shift",
     namespace=seer_tasks,
@@ -50,7 +47,7 @@
         ),
         100,
     ):
-        eligible_ids = _get_eligible_org_ids_from_batch_d7(org_batch)
+        eligible_ids = _get_eligible_org_ids_from_batch(org_batch)
 
         org_map = {org.id: org for org in org_batch}
         for org_id in eligible_ids:
@@ -102,7 +99,7 @@
     )
 
 
-def _get_eligible_org_ids_from_batch_d7(
+def _get_eligible_org_ids_from_batch(
     orgs: Sequence[Organization],
 ) -> list[int]:
     """

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit e65687b. Configure here.}

src/sentry/tasks/seer/night_shift.py

github-actions · 2026-04-07T23:23:10Z

Backend Test Failures

Failures on 83a403a in this run:

tests/sentry/taskworker/test_config.py::test_all_instrumented_tasks_registered — log

[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/taskworker/test_config.py:120: in test_all_instrumented_tasks_registered
    raise AssertionError(
E   AssertionError: Found 1 module(s) with @instrumented_task that are NOT registered in TASKWORKER_IMPORTS.
E   These tasks will not be discovered by the taskworker in production!
E   
E   Missing modules:
E     - sentry.tasks.seer.night_shift
E   
E   Add these to TASKWORKER_IMPORTS in src/sentry/conf/server.py

Add the scaffolding for a nightly cron job that fans out per-org to trigger Seer Autofix on top issues. This decouples automation from the hot post_process pipeline, enabling better issue selection and serving lower-volume orgs. Includes: - Scheduler task with batched feature flag checks and jitter - Stub per-org worker task (logic TBD) - Feature flag (organizations:seer-night-shift) and options - NIGHT_SHIFT referrer and automation source Co-Authored-By: Claude <[email protected]>

Remove spurious _d7 suffix from function name and remove unused NIGHT_SHIFT_AUTO_RUN_SOURCE constant (will be added when worker logic is implemented). Co-Authored-By: Claude <[email protected]>

Co-Authored-By: Claude <[email protected]>

wedamija · 2026-04-07T23:48:00Z

src/sentry/tasks/seer/night_shift.py

+    for org_batch in chunked(
+        RangeQuerySetWrapper[Organization](
+            Organization.objects.filter(status=OrganizationStatus.ACTIVE),
+            step=1000,
+        ),
+        100,
+    ):


Not sure if this would be useful for you since you're scheduling all of these at the same time, but I recently added a generic CursoredScheduler that might do what you want. Instead of running all the scheduled items at once, it stripes them over a period of time. This might be helpful for you so that you're not hitting Seer with a bunch of requests all at once.

https://github.com/getsentry/sentry/blob/987d0433540d52624da4390b353961c8ac0749bb/src/sentry/integrations/source_code_management/sync_repos.py#L271-L288 is an example of it being used.

Probably it'd need a few changes to let it filter tasks before scheduling, but I'd be happy enough to include them if it's helpful for you.

Something like CursoredScheduler seems compelling. If I understand CursoredScheduler correctly it ends up exposing an API like "Run foo() once per org per 24h" (where org / 24h etc can be configured). That's pretty close to the long term future of nightshift probably?

In the short term of nightshift (and more generally for experimental things) - it may be worth splitting the two parts:

One off running a function over all orgs over some period.

Scheduling when 1. happens.

In particular if you a) discover some bug in the recurring task and want to restart it/rerun it/stop it or b) want to run some one time job over all orgs. That might diverge a bit too far from the current design of CursoredScheduler though.

chromy

lgtm % some minor questions

chromy · 2026-04-08T11:42:14Z

src/sentry/tasks/seer/night_shift.py

+        if batch_result is None:
+            batch_result = {
+                f"organization:{org.id}": features.has(feature_name, org) for org in orgs
+            }


Can this happen? I would be tempted to raise here and fix batch_has_for_organizations if this is common.

chromy · 2026-04-08T11:57:27Z

src/sentry/tasks/seer/night_shift.py

+    for org_batch in chunked(
+        RangeQuerySetWrapper[Organization](
+            Organization.objects.filter(status=OrganizationStatus.ACTIVE),
+            step=1000,
+        ),
+        100,
+    ):


Something like CursoredScheduler seems compelling. If I understand CursoredScheduler correctly it ends up exposing an API like "Run foo() once per org per 24h" (where org / 24h etc can be configured). That's pretty close to the long term future of nightshift probably?

In the short term of nightshift (and more generally for experimental things) - it may be worth splitting the two parts:

One off running a function over all orgs over some period.

Scheduling when 1. happens.

In particular if you a) discover some bug in the recurring task and want to restart it/rerun it/stop it or b) want to run some one time job over all orgs. That might diverge a bit too far from the current design of CursoredScheduler though.

chromy · 2026-04-08T12:12:47Z

src/sentry/tasks/seer/night_shift.py

+
+        if not eligible:
+            return []


something like

eligible_orgs = list(orgs) for feature_name in FEATURE_NAMES: batch_result = features.batch_has_for_organizations(feature_name, eligible_orgs) eligible_orgs = [org for org in eligible_orgs if batch_result.get(f"organization:{org.id}", False)] return list(eligible)

seems like there is a little less awkward conversion between Organization, id and "organization:{id}" but this is fine also

vercel bot deployed to Preview April 7, 2026 22:56 View deployment

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 7, 2026

cursor bot reviewed Apr 7, 2026

View reviewed changes

src/sentry/tasks/seer/night_shift.py Outdated Show resolved Hide resolved

src/sentry/tasks/seer/night_shift.py Outdated Show resolved Hide resolved

vercel bot deployed to Preview April 7, 2026 23:10 View deployment

trevor-e and others added 2 commits April 7, 2026 19:27

ref(seer): Address PR feedback on night shift scaffolding

22fce6c

Remove spurious _d7 suffix from function name and remove unused NIGHT_SHIFT_AUTO_RUN_SOURCE constant (will be added when worker logic is implemented). Co-Authored-By: Claude <[email protected]>

vercel bot deployed to Preview April 7, 2026 23:27 View deployment

fix(seer): Register night shift module in TASKWORKER_IMPORTS

9308041

Co-Authored-By: Claude <[email protected]>

trevor-e force-pushed the feat/seer-night-shift-scaffolding branch from 2447b23 to 9308041 Compare April 7, 2026 23:28

vercel bot deployed to Preview April 7, 2026 23:29 View deployment

trevor-e marked this pull request as ready for review April 7, 2026 23:33

trevor-e requested review from a team as code owners April 7, 2026 23:33

wedamija reviewed Apr 7, 2026

View reviewed changes

chromy approved these changes Apr 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(seer): Add Night Shift nightly autofix cron scaffolding#112429

feat(seer): Add Night Shift nightly autofix cron scaffolding#112429
trevor-e wants to merge 3 commits intomasterfrom
feat/seer-night-shift-scaffolding

trevor-e commented Apr 7, 2026

Uh oh!

cursor bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 7, 2026

Uh oh!

wedamija Apr 7, 2026

Uh oh!

chromy Apr 8, 2026

Uh oh!

chromy left a comment

Uh oh!

chromy Apr 8, 2026

Uh oh!

chromy Apr 8, 2026

Uh oh!

chromy Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

trevor-e commented Apr 7, 2026

Uh oh!

cursor bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 7, 2026

Backend Test Failures

Uh oh!

wedamija Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

chromy Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

chromy left a comment

Choose a reason for hiding this comment

Uh oh!

chromy Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

chromy Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

chromy Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cursor bot left a comment •

edited

Loading