Skip to content

fix(issues): Always show loading toast for bulk actions #112428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
scttcper wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −6
Draft

fix(issues): Always show loading toast for bulk actions #112428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions static/app/views/issueList/actions/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {bulkDelete, bulkUpdate, mergeGroups} from 'sentry/actionCreators/group';
import {
addErrorMessage,
addLoadingMessage,
clearIndicators,
addSuccessMessage,
} from 'sentry/actionCreators/indicator';
import {IssueStreamHeaderLabel} from 'sentry/components/IssueStreamHeaderLabel';
import {Sticky} from 'sentry/components/sticky';
Expand Down Expand Up @@ -305,9 +305,7 @@ export function IssueListActions({
// * users with global views need to be explicit about what projects the query will run against
const projectConstraints = {project: getSelectedProjectIds(itemIds)};

if (itemIds?.length) {
addLoadingMessage(t('Saving changes\u2026'));
}
addLoadingMessage(t('Saving changes\u2026'));

bulkUpdate(
api,
Expand All @@ -323,7 +321,7 @@ export function IssueListActions({
},
{
success: () => {
clearIndicators();
addSuccessMessage(t('Changes saved'));
onActionTaken?.(itemIds ?? [], data);

// Prevents stale data on issue details
Expand All @@ -346,7 +344,6 @@ export function IssueListActions({
}
},
error: () => {
clearIndicators();
addErrorMessage(t('Unable to update issues'));
},
}
Expand Down
Loading