-
-
Notifications
You must be signed in to change notification settings - Fork 60
feat: native crash backend as option for Windows
#2692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
9ac7e0c
build and use sentry-native on macos
bitsandfoxes 80de807
fix targets, fix buildpostprocess
bitsandfoxes be90a21
Merge branch 'main' into feat/macos-native
bitsandfoxes 78e285d
meta data
bitsandfoxes c80ad0b
closing
bitsandfoxes c47d1ad
CI
bitsandfoxes 176209d
make backend experimental
bitsandfoxes 6e21b3c
rebased on top of feat/macos-native
bitsandfoxes 6dafbf1
updated snapshot
bitsandfoxes f64e5e1
Merge branch 'feat/macos-native' into feat/windows-native-backend
bitsandfoxes 786ba8d
fallback to branch for downloading the native sdk
bitsandfoxes 558843c
cleanup
bitsandfoxes 598d6c8
updated changelog
bitsandfoxes 1578bf6
upsi. merge-derp
bitsandfoxes cc6cb37
clean up with every build
bitsandfoxes 5a756d6
permissions
bitsandfoxes a2cc9a1
refactor buildpostprocess
bitsandfoxes e1babe7
floor the shutdown timeout
bitsandfoxes f20242e
reverted change to samples
bitsandfoxes 138641d
updated options .asset file
bitsandfoxes ec2b258
ismacos
bitsandfoxes c933961
merged macos-native feature
bitsandfoxes 12dc60d
simplified native sdk download fallbacks
bitsandfoxes 96db359
merged main
bitsandfoxes 442b943
updated changelog
bitsandfoxes 10f5ab3
crashpad with no pdb
bitsandfoxes 8b5af5b
.
bitsandfoxes 03bcc20
Merge branch 'main' into feat/windows-native-backend
bitsandfoxes a9e598a
updated snapshot
bitsandfoxes ad1c58e
revert unrelated changelog changes
bitsandfoxes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The
EnsureWindowsNativeSDKbuild target runs on every Windows build ifsentry.dllis missing, even when the native backend is disabled, causing unnecessary build failures.Severity: MEDIUM
Suggested Fix
Modify the condition for the
EnsureWindowsNativeSDKtarget to also check if the native backend is enabled for the current build. This could be done by checking a property that indicates the selected backend, preventing the target from running when it's not needed.Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.