fix: resolve sentry-cli relative to react-native package#6240
Closed
shawnthye-guru wants to merge 1 commit into
Closed
fix: resolve sentry-cli relative to react-native package#6240shawnthye-guru wants to merge 1 commit into
shawnthye-guru wants to merge 1 commit into
Conversation
|
This PR has been automatically closed. All non-maintainer contributions must reference an existing GitHub issue. Next steps:
Please review our contributing guidelines for more details. |
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@sentry/clifrom@sentry/react-native's package location in the Android Gradle integrationWhy
Package managers with isolated dependency layouts, such as pnpm, may not make
@sentry/clidirectly resolvable from the app's native project directory even though it is available as a dependency of@sentry/react-native. Resolving with{ paths: [require.resolve('@sentry/react-native/package.json')] }lets Node resolve the CLI from the React Native SDK dependency graph before falling back to the existing pnpm shim parsing.Validation
bash -n packages/core/scripts/sentry-xcode.shbash -n packages/core/scripts/sentry-xcode-debug-files.shgit diff --checksentry-clipath in a pnpm React Native app where plainrequire.resolve('@sentry/cli/package.json')fails